Repository navigation
fix(git): preserve grapheme clusters in fish-style abbreviations - #790
Merged
sirmalloc merged 4 commits intoNov 5, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #789.
Use the existing
getGraphemeshelper when abbreviating Git branch and worktree names. The first displayed character now stays intact for flags, ZWJ emoji, combining marks, skin-tone modifiers, and variation selectors. The final path segment and unabridged names keep their current behavior.Adds fourteen rendering cases across the existing widget tests, including single-segment names and a final-segment control. The new failing cases use clusters at the start of a segment, where fish-style abbreviation actually truncates.
Validation:
bun test,bun run lint, andbun run buildall pass.No dependency or runtime-floor changes; this reuses the helper's existing fallback for runtimes without
Intl.Segmenter.