Repository navigation
feat(tui): pick 256-color colors from a grid in Edit Colors - #778
Merged
Merged
Conversation
(a) in Edit Colors opens the whole 256-color palette as a grid (the 16 basic colors, the 6x6x6 cube and the 24 grays) instead of asking for a number. The arrow keys move the cursor and the preview follows it, typing a number jumps to that color, Enter keeps it and ESC restores the previous one. Picks are still saved as ansi256:N, and (a) is now offered at truecolor too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo
Opening the grid on Model's background (Blue), moving through the color cube with the preview following, and keeping a color with Enter. Powerline mode uses the Custom theme, since a named theme locks Edit Colors.
Powerline
Plain
Summary
In Edit Colors, (a) asked for a palette number from 0 to 255, so picking a 256-color color meant knowing its number already. (a) now opens the whole palette as a grid:
208→ ANSI 208). A digit that would go past 255 starts a new number.[]in black or white, whichever reads better on it. Terminals narrower than 76 columns get one-character cells.Behavior details
(h)ex, (a)nsi256.ansi256:N, as the typed prompt did, so the settings format doesn't change and a pick renders as its swatch. That includes the basic colors: a named color likeredis drawn with other colors (160 at 256 colors,#CC0000at truecolor), so saving the name would change the color from the one picked. Like anyansi256:Ncolor, a basic pick resets to the widget's default when the color level changes, as onmain.redon 160 at 256 colors), and a hex color on the nearest cube or gray color. The widget keeps its color until the cursor moves, so opening the grid and pressing Enter never changes it, and the preview always shows what Enter keeps.docs/USAGE.md(Widget Styling) now lists (a) and (h).Testing
mainas of fix: use env override and settings for usable context ratio calculation #407 (71e8b42): merges cleanly,bun run lintis clean, andbun testgives 3967 pass, 0 fail. The built CLI under Bun 1.4.4 and Node 26.13.0 matchesmainin plain and Powerline mode with the baseline configs, and the TUI opens and exits cleanly. It adds no JavaScript or Node API newer than Node 14, the build's target.bun run lintandbun test(2,493 pass), including new tests:color-menu/__tests__/palette.test.ts: the layout (every color placed exactly once), movement and wrapping, xterm hex values, labels, marker contrast, saved values and starting positions.__tests__/ColorMenuPalette.test.tsx: opening at 256 colors and truecolor but not at 16, the live preview while moving, typing a number, Enter, ESC, background mode, narrow terminals, and unchanged settings when opened on a palette color.mainunder Bun 1.4.2 and Node 18, 22 and 26, in plain and Powerline modes, and the TUI opens and exits cleanly on each.