Repository navigation
test(config): give each run its own temp home directory - #653
Merged
Merged
Conversation
The config tests used a fixed /tmp/ccstatusline-config-test-home and deleted it before every test. Two test runs at once (an editor's test runner plus a terminal run, or parallel CI jobs on one machine) deleted each other's settings files mid-test and failed at random. Run three at a time, the file failed 128 of 345 tests on main. A directory from mkdtempSync is unique to each run, so they no longer collide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No demo: only a test changes.
Summary
src/utils/__tests__/config.test.tsused a fixed directory,/tmp/ccstatusline-config-test-home, and deleted it before every test. Two test runs on the same machine at once delete each other's settings files mid-test and fail at random. Examples: an editor's test runner alongside a terminal run, or parallel CI jobs on one runner.The directory now comes from
fs.mkdtempSync(path.join(os.tmpdir(), 'ccstatusline-config-test-home-')), unique to each run. Everything else in the file is unchanged: it still clears the directory before each test and removes it at the end.Testing
config.test.tsunder Node three at a time, five rounds:main: 128 of 345 tests failed.bun run lintandbun testpass; the file passes under Bun and under Node with Vitest.