[eric-engberg]

Test-only. #607, #609 and #593 also touch some of these test files; happy to rebase either way.

No demo: only tests change, and nothing in the TUI or the status line looks different.

Summary

The Ink component tests slept a fixed 25ms (flushInk()) after rendering and after every key, then asserted. Ink redraws, and React re-attaches Ink's input listener, on their own schedule. On a loaded machine the assertion runs before the redraw, or the next key arrives while the listener is detached and is dropped. These tests fail intermittently under CPU load, as on a busy CI runner or with several test runs going at once.

Each test now waits for the visible effect of its key, with a timeout:

• the selection marker moving;
• a prompt or search result appearing;
• a callback firing.

The waits go through a small shared helper, src/tui/__tests__/helpers/wait-for-ink.ts. After each successful wait it yields two setImmediate turns, which lets React run the passive effect that re-attaches the input listener before the next key.

No assertions change. Where a test checks that something did not happen, it does so after waiting for the positive effect. A few stdout mocks gained the clearOutput() that the others already had, so a wait only matches the new frame.

Covered (11 files): GlobalOverridesMenu, ImportPreviewDialog, InstallMenu, PowerlineSetup, PowerlineThemeSelector, RefreshIntervalMenu, StatusLinePreview and TerminalWidthMenu, plus the locale, timezone and symbol-override editors. ItemsEditor.test.ts and ColorMenu.test.tsx use the same pattern; they're left out here because I'm changing those files in other work and will convert them there.

Testing

• Reproducing the flakiness: I ran the 11 files under Node with four CPU-busy loops and three runs at a time, 12 runs per side:
  • main: 24 failures in 912 tests, across TerminalWidthMenu (7), RefreshIntervalMenu (9), the timezone editor (7) and the locale editor (1).
  • This branch: 0 failures in 912 tests, though the load during its turn was higher (19.5 against 12).
  • The same tests also failed earlier on main when two full suites ran at once, along with the symbol-override editor and ImportPreviewDialog.
• bun run lint and bun test (2,358 pass).
• Under Node with Vitest: the full suite fails in the same 17 files as main (all from spying on Node built-ins), and all 11 changed files pass.