ghMentions does not work with username having dots

[davidsandoz]

Description

In GitLab, dots are allowed in usernames (unlike in GitHub). When using ghMentions with ghMentionsLink, if the given username contains a dot, the link is made only with what is before the dot.

Input

@john.doe

With the following showdown options:

{
    ghMentions: true,
    ghMentionsLink: 'https://gitlab.example.com/{u}',
}

Expected output

<a href="https://gitlab.example.com/john.doe>@john.doe</a>

Actual output

<a href="https://gitlab.example.com/john>@john</a>.doe

[tivie]

Github only allows dashes in the middle of the name.

[davidsandoz]

@tivie You're right. But I'm using showdown with GitLab.

[tivie]

I will make showdown allow dashes, underscores and dots in the middle of the username, since that seems a valid usecase scenario

[tivie]

Should be fixed now

[davidsandoz]

Awesome, thanks! Do you have an idea when will the next release happen?

[tivie]

Soonish I hope. Version 2.0-alpha will be the next release.

[tivie]

---

Donate

As you know, ShowdownJS is a free library and it will remain free forever. However, maintaining and improving the library costs time and money.
If you like our work and find our library useful, please donate through Pledgie or directly through paypal!! Your contribution will be greatly appreciated and help us continue to develop this awesome library.

[davidsandoz]

Done 😉