fix: correct R2 bucket name and install AWS CLI in publish-manifest - #656
Merged
Merged
Conversation
Two bugs vs the working R2 workflows: - Bucket was codepathfinder-assets, must be code-pathfinder-assets (matches stdlib-r2-upload.yml, go-stdlib-r2-upload.yml, etc.) - AWS CLI was not installed before use; all other R2 workflows explicitly curl + install the latest version for consistency Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
shivasurya
added
bug
SafeDep Report Summary
No dependency changes detected. Nothing to scan. This report is generated by SafeDep Github App |
Code Pathfinder Security Scan
No security issues detected.
Powered by Code Pathfinder |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #656 +/- ##
=======================================
Coverage 84.90% 84.91%
=======================================
Files 172 172
Lines 24879 24879
=======================================
+ Hits 21124 21126 +2
+ Misses 2965 2964 -1
+ Partials 790 789 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two bugs in
.github/workflows/publish-manifest.ymlfound by comparing against the working R2 upload workflows (stdlib-r2-upload.yml,go-stdlib-r2-upload.yml,go-thirdparty-r2-upload.yml):codepathfinder-assets→code-pathfinder-assets— this causedAccessDeniedon the first workflow run after mergecurl + installthe latest AWS CLI before use; relying on the pre-installed runner version is inconsistent and fragileRoot cause
The bucket name typo in the original PR (#655) was not caught because the workflow only runs on push to
main(no PR-level test path existed).🤖 Generated with Claude Code