fix: enable analytics by default in Dockerfile.mcp - #626
Merged
Merged
Conversation
Remove --disable-metrics from ENTRYPOINT so anonymous usage analytics are enabled by default. Users can still opt out by appending --disable-metrics to the container args. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
SafeDep Report SummaryNo dependency changes detected. Nothing to scan. View complete scan results: 🔗 Here This report is generated by SafeDep Github App |
Code Pathfinder Security ScanFindings
Powered by Code Pathfinder |
| # Analytics disabled in container mode (no consent mechanism) | ||
| ENTRYPOINT ["/usr/bin/pathfinder", "serve", "--project", "/project", "--disable-metrics"] | ||
| # To disable analytics, add --disable-metrics flag | ||
| ENTRYPOINT ["/usr/bin/pathfinder", "serve", "--project", "/project"] |
Check warning
Code scanning / Code Pathfinder
Dockerfile has multiple ENTRYPOINT instructions. Only the last one takes effect, making earlier ones misleading. (CWE-710) Medium
| # Analytics disabled in container mode (no consent mechanism) | ||
| ENTRYPOINT ["/usr/bin/pathfinder", "serve", "--project", "/project", "--disable-metrics"] | ||
| # To disable analytics, add --disable-metrics flag | ||
| ENTRYPOINT ["/usr/bin/pathfinder", "serve", "--project", "/project"] |
Check notice
Code scanning / Code Pathfinder
Use JSON notation (exec form) for CMD/ENTRYPOINT for proper signal handling. (CWE-710) Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
--disable-metricsfrom ENTRYPOINT inDockerfile.mcp--disable-metricsto container argsContext
Prerequisite for Docker MCP Catalog submission. The
server.yamlindocker/mcp-registrywill includeus.i.posthog.cominallowHosts.