Repository navigation
feat: deep call chain resolution for VDG taint analysis (GAP-004) - #623
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… (GAP-004) Change extractCallTarget to return (target, chain) where target is the bare method name and chain is the full dotted path. Thread CallChain through extractCall and extractAssignment (including subscript-on-call). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…n (GAP-004) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
SafeDep Report SummaryNo dependency changes detected. Nothing to scan. View complete scan results: 🔗 Here This report is generated by SafeDep Github App |
Code Pathfinder Security ScanNo security issues detected.
Powered by Code Pathfinder |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #623 +/- ##
==========================================
+ Coverage 83.91% 84.04% +0.12%
==========================================
Files 156 156
Lines 21454 21474 +20
==========================================
+ Hits 18003 18047 +44
+ Misses 2802 2779 -23
+ Partials 649 648 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add tests for augmented assignment, bare call with chain, and lambda call expressions to cover previously untested code paths. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Parameters with identical Line values caused non-deterministic sort order in getParamNamesForFQN, making the tracked param index mapping random. Give params distinct line numbers for stable ordering. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
CallChainfield toStatementstoring full dotted attribute chain for method calls (e.g.,"request.args.get"instead of just"get")extractCallTargetto return both bare method name and full chain in extraction and CFG builderCallChainthrough VDGBuild()andFindTaintFlows()for precise source/sink/sanitizer matchingcalls("request.args.get")andcalls("*.config.get")to match precisely without false positives fromdict.get(),list.get(), etc.Test plan
calls("*.config.get")matchesself.pyload.config.get()— 1 findingcalls("request.args.get")matches precisely — 1 findingcalls("*.get")backward compat — still worksgradle lintGo— 0 issuesgradle buildGo— BUILD SUCCESSFULgradle testGo— 368 Python + 29 Go packages passed🤖 Generated with Claude Code