feat(mcp): Add --disable-metrics flag to MCP serve command and remove nsjail - #506
Merged
Merged
Conversation
… nsjail - Pass --disable-metrics flag through to MCP analytics layer for serve command - Add disabled field to MCP Analytics struct with early-return in all report methods - Preserve disable state across transport switches (stdio → http) - Remove nsjail sandboxing code from DSL loader, Dockerfile, and entrypoint - Fix all prealloc lint warnings across 8 files - Add comprehensive tests for disabled analytics and serve command flags Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
==========================================
+ Coverage 80.92% 81.13% +0.21%
==========================================
Files 113 113
Lines 13320 13302 -18
==========================================
+ Hits 10779 10793 +14
+ Misses 2136 2107 -29
+ Partials 405 402 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--disable-metricspersistent flag through to MCP analytics layer in serve commandChanges
disabledfield to MCPAnalyticsstruct with early-return guards on all report methodsdisableAnalyticsthroughNewServerandSetTransportisSandboxEnabled(),buildNsjailCommand(), nsjail Docker install, and sandbox env varsTesting
gradle buildGo- Build successfulgradle testGo- All 24 Go packages + 300 Python tests passgradle lintGo- 0 issues🤖 Generated with Claude Code