Skip to content

fix(dsl): Make single-file rule loading consistent with directory behavior - #501

Merged
shivasurya merged 1 commit into
mainfrom
shiva/fix-rule-bug
Feb 2, 2026
Merged

shivasurya merged 1 commit into
mainfrom
shiva/fix-rule-bug

Conversation

@shivasurya

Copy link
Copy Markdown
Owner

Changes

  • Return empty list instead of error for files without code analysis rules
  • Add debug logging for container rule loading failures
  • Add validation to ensure at least one type of rule is loaded

Testing

  • Updated existing tests
  • Added new test cases for container rule files
  • All tests passing (300 Python + all Go tests)

…avior

- Return empty list instead of error for files without code analysis rules
- Add debug logging for container rule loading failures
- Add validation to ensure at least one type of rule is loaded
- Update and add test cases to cover the fix
@shivasurya shivasurya added bug Something isn't working go Pull requests that update go code labels Feb 2, 2026
@shivasurya shivasurya self-assigned this Feb 2, 2026
@safedep

safedep Bot commented Feb 2, 2026 •

Copy link
Copy Markdown

SafeDep Report Summary

Green Malicious Packages Badge Green Vulnerable Packages Badge Green Risky License Badge

No dependency changes detected. Nothing to scan.

This report is generated by SafeDep Github App

@shivasurya
shivasurya merged commit 493d18b into main Feb 2, 2026
5 checks passed
@shivasurya
shivasurya deleted the shiva/fix-rule-bug branch February 2, 2026 01:31
@codecov

codecov Bot commented Feb 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.14%. Comparing base (224d996) to head (a60bf5e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sast-engine/cmd/scan.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
- Coverage   81.19%   81.14%   -0.05%     
==========================================
  Files         113      113              
  Lines       13294    13302       +8     
==========================================
  Hits        10794    10794              
- Misses       2095     2103       +8     
  Partials      405      405              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working go Pull requests that update go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant