Repository navigation
fix(data): supervise an unterminated final Muse span - #1167
Open
subhajitdchow wants to merge 1 commit into
Open
subhajitdchow wants to merge 1 commit into
subhajitdchow wants to merge 1 commit into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
@yudigege86 MuseParser on the EAGLE4 branch (#1024) has the same closing-token requirement; this fixes it on main. |
subhajitdchow
marked this pull request as ready for review
November 10, 2026 22:39
subhajitdchow
requested review from
FrankLeeeee,
shuaills,
sleepcoo and
zyksir
as code owners
November 10, 2026 22:39
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MuseParsersupervises an assistant span only when it ends in<|eom|>or<|eot|>. A reply cut offby the generation length cap has no closing token, so its last span gets no loss. When the reply is cut
inside its first span, the row has no trainable tokens and is filtered out.
Modifications
(?:<\|eom\|>|<\|eot\|>|$). No closing token is added,so the draft does not learn a stop the target never produced.
MuseParserdocstring.test_unterminated_final_span_is_supervised.Complete spans are unchanged: the match still stops at the first closing token.
Related Issues
MuseParser)Accuracy Test
tests/test_data/test_muse_parser.py: the new test fails onmainand passes with this change; theexisting Muse parser tests pass unchanged.
Benchmark & Profiling
N/A. Loss-mask change only.
Checklist