Fix broken codegen, use rustfmt instead - #313
Merged
Merged
Conversation
Signed-off-by: Simon Sapin <simon@igalia.com>
mrobinson
approved these changes
Sep 14, 2026
When rustup is installed but rustfmt is not, `~/.cargo/bin/rustfmt` exists and prints and error message. `Command::spawn` succeeds, but we need to check the exist status. Signed-off-by: Simon Sapin <simon@igalia.com>
SimonSapin
enabled auto-merge
September 14, 2026 16:11
Signed-off-by: Simon Sapin <simon@igalia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #311 and fixes #312, building on top of it to add optional use of
rustfmtto format generated code. If rustfmt is not available, fall back silently to writing unformatted code.