Skip to content

Maybe remove the 'unreachable' crate dependency? #128

Closed
Closed
Maybe remove the 'unreachable' crate dependency?#128

Description

@frewsxcv
frewsxcv
opened on Oct 4, 2018

rust-smallvec/lib.rs

Lines 48 to 49 in feb3e45

extern crate unreachable;
use unreachable::UncheckedOptionExt;

rust-smallvec/lib.rs

Line 762 in feb3e45

unsafe { self.pop().unchecked_unwrap() }

Seems like we might be able to replace this usage with this:

use std::hint;

// ...

unsafe {
    self.pop().unwrap_or_else(hint::unreachable_unchecked)
}

Activity

  1. mbrubeck commented on Oct 8, 2018

    @mbrubeck
    mbrubeck
    on Oct 8, 2018
    Collaborator

    This would increase the minimum supported Rust version from 1.20 to 1.27. Since this crate is so widely used, we try to batch such changes together along with other breaking changes. Added this to the tracking bug (#73).

  2. mbrubeck
    added a commit that references this issue on Feb 16, 2019

    Remove dependency on unmaintained 'unreachable'

    2511b81
  3. bors-servo
    added a commit that references this issue on Feb 16, 2019

    Auto merge of #140 - mbrubeck:unreachable, r=emilio

    dfd78d1
  4. bors-servo
    closed this as completedin #140on Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions