Add CI check to ensure mozjs is bumped - #677
Conversation
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
sagudev
left a comment
There was a problem hiding this comment.
Should we also request bump for any changes in mozjs? Or maybe is this planed as part of other PRs.
Tbh, I did not consider that yet. I guess we would want a release for every change, since the repos are tightly coupled, so it would make sense to require that. |
|
Hm, actually it is safe to not bump mozjs version for any change (but we need this for mozjs-sys because of artifacts), so maybe we do not need this PR? I can see how it could be useful (to not forget bump if one wants to use this in servo), but also not if we want to land multiple PRs (in short span of time) and not release version for each one (I am worried we will spam to many version - and our crates are big). |
b91e2e3 to
58232eb
Compare
|
Okay, I can make a seperate PR for the mozjs detection, and we can discuss that there. Removed the changes from here again. |
For purposes of publishing to crates.io, we should also bump the
mozjsversion number, and update the dependency on mozjs-sys.cargowill give an error, if we update the mozjs-sys version inmozjs-sys/Cargo.toml, but forget to update the dependency inmozjs/Cargo.tomlsince we depend on an exact version by using the=specifier.The only thing we need to check in CI is that the mozjs version is also bumped, since that would prevent publishing to crates.io (without further changes).