Skip to content

Add CI check to ensure mozjs is bumped - #677

Merged
jschwe merged 1 commit into
servo:mainfrom
jschwe:jschwender/ci-bump-mozjs
Dec 5, 2025
Merged

jschwe merged 1 commit into
servo:mainfrom
jschwe:jschwender/ci-bump-mozjs

Conversation

@jschwe

@jschwe jschwe commented Dec 4, 2025

Copy link
Copy Markdown
Member

For purposes of publishing to crates.io, we should also bump the mozjs version number, and update the dependency on mozjs-sys. cargo will give an error, if we update the mozjs-sys version in mozjs-sys/Cargo.toml, but forget to update the dependency in mozjs/Cargo.toml since we depend on an exact version by using the = specifier.
The only thing we need to check in CI is that the mozjs version is also bumped, since that would prevent publishing to crates.io (without further changes).

Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>

@sagudev sagudev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also request bump for any changes in mozjs? Or maybe is this planed as part of other PRs.

@jschwe

jschwe commented Dec 4, 2025

Copy link
Copy Markdown
Member Author

Should we also request bump for any changes in mozjs? Or maybe is this planed as part of other PRs.

Tbh, I did not consider that yet. I guess we would want a release for every change, since the repos are tightly coupled, so it would make sense to require that.

@sagudev

sagudev commented Dec 4, 2025

Copy link
Copy Markdown
Member

Hm, actually it is safe to not bump mozjs version for any change (but we need this for mozjs-sys because of artifacts), so maybe we do not need this PR? I can see how it could be useful (to not forget bump if one wants to use this in servo), but also not if we want to land multiple PRs (in short span of time) and not release version for each one (I am worried we will spam to many version - and our crates are big).

@jschwe
jschwe force-pushed the jschwender/ci-bump-mozjs branch from b91e2e3 to 58232eb Compare December 4, 2025 19:14
@jschwe

jschwe commented Dec 4, 2025 •

Copy link
Copy Markdown
Member Author

Okay, I can make a seperate PR for the mozjs detection, and we can discuss that there. Removed the changes from here again.
Edit: Although I think that just mozjs itself would be quite a small crate.

@jschwe
jschwe added this pull request to the merge queue Dec 5, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Dec 5, 2025
@jschwe
jschwe added this pull request to the merge queue Dec 5, 2025
@jschwe
jschwe removed this pull request from the merge queue due to a manual request Dec 5, 2025
@jschwe
jschwe added this pull request to the merge queue Dec 5, 2025
Merged via the queue into servo:main with commit 01d0586 Dec 5, 2025
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants