Skip to content

[theme] make text-secondary darker, chart-grid-text-label lighter - #3216

Merged
Valeria-Zimnitskaya merged 5 commits into
release/v18from
UIK-6049/text-secondary-darker
Oct 6, 2026
Merged

Valeria-Zimnitskaya merged 5 commits into
release/v18from
UIK-6049/text-secondary-darker

Conversation

@sheila-semrush

@sheila-semrush sheila-semrush commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Motivation and Context

  • make text-secondary darker because otherwise muted tertiary buttons look disabled
  • make chart-grid-text-label lighter than text-secondary to keep it light

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • I have updated the documentation accordingly.
  • I have added new tests on added of fixed functionality.

@Valeria-Zimnitskaya
Valeria-Zimnitskaya merged commit bb1fc6b into release/v18 Oct 6, 2026
2 checks passed
@Valeria-Zimnitskaya
Valeria-Zimnitskaya deleted the UIK-6049/text-secondary-darker branch October 6, 2026 21:15
ilyabrower pushed a commit that referenced this pull request Oct 7, 2026
)

<!--- Provide a general summary of your changes in the Title above -->

## Motivation and Context

- make text-secondary darker because otherwise muted tertiary buttons
look disabled
- make chart-grid-text-label lighter than text-secondary to keep it
light

## How has this been tested?

<!--- Please describe in detail how you tested your changes. -->
<!--- For example: -->
<!--- I have added unit tests -->
<!--- I have added Voice Over tests -->
<!--- Code cannot be tested automatically so I have tested it only
manually -->

## Screenshots (if appropriate):

## Types of changes

<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue).
- [ ] New feature (non-breaking change which adds functionality).
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected).
- [ ] Nice improve.

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [ ] I have updated the documentation accordingly.
- [ ] I have added new tests on added of fixed functionality.

---------

Signed-off-by: Valeria-Zimnitskaya <valeryia.zimnitskaya@semrush.com>
Co-authored-by: Valeria-Zimnitskaya <valeryia.zimnitskaya@semrush.com>
ilyabrower pushed a commit that referenced this pull request Oct 8, 2026
)

<!--- Provide a general summary of your changes in the Title above -->

## Motivation and Context

- make text-secondary darker because otherwise muted tertiary buttons
look disabled
- make chart-grid-text-label lighter than text-secondary to keep it
light

## How has this been tested?

<!--- Please describe in detail how you tested your changes. -->
<!--- For example: -->
<!--- I have added unit tests -->
<!--- I have added Voice Over tests -->
<!--- Code cannot be tested automatically so I have tested it only
manually -->

## Screenshots (if appropriate):

## Types of changes

<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue).
- [ ] New feature (non-breaking change which adds functionality).
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected).
- [ ] Nice improve.

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [ ] I have updated the documentation accordingly.
- [ ] I have added new tests on added of fixed functionality.

---------

Signed-off-by: Valeria-Zimnitskaya <valeryia.zimnitskaya@semrush.com>
Co-authored-by: Valeria-Zimnitskaya <valeryia.zimnitskaya@semrush.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment