Repository navigation
refactor: move harness/{faults,bench} to test/manifests/{faults,bench} - #580
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
PR SummaryLow Risk Overview
Reviewed by Cursor Bugbot for commit e55349e. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
This PR moves the fault catalog and seiload Job renderer from harness/{faults,bench} to test/manifests/{faults,bench} using a pure rename, and updates the integration-suite imports and the .dockerignore re-include for the embedded templates to match. Nothing in the tree still points at the old paths and the embed re-include follows the move, so nothing blocks; I kept codex's import-path point as a non-blocking note, since the PR description already covers seictl's migration.
Non-blocking
- No shim is left at harness/{faults,bench}, so any external importer stops compiling at the old paths when it bumps its pin (raised by codex). seictl is safe for now because it pins badf30d, but the chaos/cmd.go, bench/cmd.go and mcp/server.go import changes the description lists need to land in the same seictl change as the pin bump.
seidroid review · decision approve · session 0ea8b1c14bab443abf96d27e47ac53c3 · turn resp_claude_4dbf64b036fec91c8da45b150e672d1a · item 3861213f9ab45a59b7a62ea48dddb6f4
Findings: 0 blocking | 1 non-blocking | 0 posted inline
…manifests (#262) ## Summary sei-protocol/sei-k8s-controller#580 moved the fault catalog and the seiload Job renderer from `harness/{faults,bench}` to `test/manifests/{faults,bench}`. The package names and API didn't change. This PR bumps the controller pin to that merge commit and rewrites the imports in `chaos/`, `bench/` and `mcp/server.go`: ``` - github.com/sei-protocol/sei-k8s-controller/harness/{faults,bench} + github.com/sei-protocol/sei-k8s-controller/test/manifests/{faults,bench} ``` The pin moves from `badf30d` to `a6d5bd6`, which also brings in the controller commits merged in between. `go build`, `go vet` and `go test ./...` all pass. `sidecarapi` stays on its own `replace` pin. Link to Devin session: https://app.devin.ai/sessions/529b10a4cbc7445895aa6189f10b28f7 Open in Devin Desktop: https://app.devin.ai/desktop/session/529b10a4cbc7445895aa6189f10b28f7?variant=devin Requested by: @bdchatham Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Summary
harness/at the repo root held only the Chaos-Mesh fault catalog and the seiload Job renderer. It isn't a harness, and nothing in the controller runtime uses it. Its consumers are the nightly integration suite andseictl chaos|bench render. This PR moves it next to the suite that uses it:git mv. Package names, exported API (faults.Catalog,Fault.Render,bench.Render) and the rendered bytes are all unchanged..dockerignorere-include changes from!harness/**/*.tmplto!test/manifests/**/*.tmpl. Without it, the integration-harness image build fails on the//go:embedtemplates.sei.io/harness-runlabel is a runtime contract with the suite, the SDK and seictl, so it stays as is.seictl: its go.mod pins the controller at
badf30d(the commit that addedharness/), so this PR doesn't break it. When seictl next bumps the pin, its imports inchaos/cmd.go,bench/cmd.goandmcp/server.goneed to change from.../harness/{faults,bench}to.../test/manifests/{faults,bench}.Link to Devin session: https://app.devin.ai/sessions/529b10a4cbc7445895aa6189f10b28f7
Open in Devin Desktop: https://app.devin.ai/desktop/session/529b10a4cbc7445895aa6189f10b28f7?variant=devin
Requested by: @bdchatham