Skip to content

Drop stale IBC wording from comments, docs and test fixtures - #4420

Merged
masih merged 2 commits into
mainfrom
masih/1790889304-ibc-doc-tidy
Oct 1, 2026
Merged

masih merged 2 commits into
mainfrom
masih/1790889304-ibc-doc-tidy

Conversation

@masih

@masih masih commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

After #4337 and #4340 removed the IBC modules, stores and upgrade state, a few places in the tree still describe behaviour in terms of IBC that no longer exists on Sei: the tokenfactory validateCreateDenom check calls itself a temporary workaround for an IBC bug, the sc-keep-recent comment in the docker app.toml files and the v2 config migration guide justifies the default with IBC relayers, the vendored sei-cosmos/x/README.md points at ibc-go, the x/upgrade client spec lists ibc, transfer and vesting module versions, and two store-hash tests mount a store named ibc.

This PR only rewords and relabels. The tokenfactory check is kept as-is because refusing a subdenom that collides with a denom that already has supply is still correct; only the comment and error string change, and nothing asserts on the old text. The two hash tests mount evm instead of ibc; they derive their expectations from the stores they create rather than from golden hashes, so the rename does not alter what they verify. No runtime, state or consensus behaviour changes.

@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedOct 1, 2026, 9:22 PM

@masih
masih marked this pull request as ready for review October 1, 2026 21:18
@masih
masih requested a review from alexander-sei October 1, 2026 21:18
@cursor

cursor Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Comment, documentation, and test fixture renames only; tokenfactory validation and runtime config values are unchanged.

Overview
Removes leftover IBC references from comments, docs, and test fixtures after IBC was dropped from the chain—no logic or config value changes.

Tokenfactory validateCreateDenom still rejects subdenoms that match a native denom with supply; only the comment and error text drop the “temporary IBC bug” wording.

sc-keep-recent comments in docker app.toml and the Sei v2 config migration doc now explain the default as enabling proofs against the previous commit instead of IBC relayers.

Docs: vendored sei-cosmos/x/README.md no longer links to ibc-go; upgrade client spec examples drop ibc, transfer, and vesting from module-version samples and use staking in the CLI example.

Tests: hash consistency and memiavl WAL replay tests mount an evm store key instead of ibc; expectations are derived from mounted stores, so verification intent is unchanged.

Reviewed by Cursor Bugbot for commit 58e95e1. Bugbot is set up for automated code reviews on this repo. Configure here.

@seidroid seidroid Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR removes leftover IBC wording from comments, docs and test fixtures. It changes no runtime, state or consensus behaviour: the tokenfactory supply check stays the same, nothing asserts on the old error text, and the hash tests compute their expectations from the stores they mount. The only defect is in a docs example, so it does not block. I kept the one finding from the codex reading because it holds.

Non-blocking

1 finding on the changed lines, as inline comments.

seidroid review · decision approve · session e4d418404ee5428082077b805351de33 · turn resp_claude_de02e794bb431fead96f9e99310e26b4 · item e32c65e2b98259599d3abf9969bf3375

Findings: 0 blocking | 1 non-blocking | 1 posted inline

Comment thread sei-cosmos/x/upgrade/spec/04_client.md
@masih
masih enabled auto-merge October 1, 2026 21:26
@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 55.69%. Comparing base (1c2b3a2) to head (58e95e1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
x/tokenfactory/keeper/createdenom.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4420   +/-   ##
=======================================
  Coverage   55.69%   55.69%           
=======================================
  Files        2177     2177           
  Lines      169045   169047    +2     
=======================================
+ Hits        94150    94155    +5     
+ Misses      74890    74887    -3     
  Partials        5        5           
Flag Coverage Δ
sei-chain 53.85% <0.00%> (+<0.01%) ⬆️
sei-db 74.81% <ø> (-0.25%) ⬇️
sei-db-state-db 78.59% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
x/tokenfactory/keeper/createdenom.go 94.33% <0.00%> (+1.74%) ⬆️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masih
masih added this pull request to the merge queue Oct 1, 2026
Merged via the queue into main with commit 33a7e56 Oct 1, 2026
68 checks passed
@masih
masih deleted the masih/1790889304-ibc-doc-tidy branch October 1, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants