Repository navigation
Drop stale IBC wording from comments, docs and test fixtures - #4420
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
PR SummaryLow Risk Overview Tokenfactory
Docs: vendored Tests: hash consistency and memiavl WAL replay tests mount an Reviewed by Cursor Bugbot for commit 58e95e1. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
This PR removes leftover IBC wording from comments, docs and test fixtures. It changes no runtime, state or consensus behaviour: the tokenfactory supply check stays the same, nothing asserts on the old error text, and the hash tests compute their expectations from the stores they mount. The only defect is in a docs example, so it does not block. I kept the one finding from the codex reading because it holds.
Non-blocking
1 finding on the changed lines, as inline comments.
seidroid review · decision approve · session e4d418404ee5428082077b805351de33 · turn resp_claude_de02e794bb431fead96f9e99310e26b4 · item e32c65e2b98259599d3abf9969bf3375
Findings: 0 blocking | 1 non-blocking | 1 posted inline
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4420 +/- ##
=======================================
Coverage 55.69% 55.69%
=======================================
Files 2177 2177
Lines 169045 169047 +2
=======================================
+ Hits 94150 94155 +5
+ Misses 74890 74887 -3
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
After #4337 and #4340 removed the IBC modules, stores and upgrade state, a few places in the tree still describe behaviour in terms of IBC that no longer exists on Sei: the tokenfactory
validateCreateDenomcheck calls itself a temporary workaround for an IBC bug, thesc-keep-recentcomment in the dockerapp.tomlfiles and the v2 config migration guide justifies the default with IBC relayers, the vendoredsei-cosmos/x/README.mdpoints at ibc-go, thex/upgradeclient spec listsibc,transferandvestingmodule versions, and two store-hash tests mount a store namedibc.This PR only rewords and relabels. The tokenfactory check is kept as-is because refusing a subdenom that collides with a denom that already has supply is still correct; only the comment and error string change, and nothing asserts on the old text. The two hash tests mount
evminstead ofibc; they derive their expectations from the stores they create rather than from golden hashes, so the rename does not alter what they verify. No runtime, state or consensus behaviour changes.