Repository navigation
fix(evmonly): continue block execution past stale nonces #4229
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,166 @@ | ||
| package rpc | ||
|
|
||
| import ( | ||
| "context" | ||
| "errors" | ||
| "math/big" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/ethereum/go-ethereum/common" | ||
| "github.com/ethereum/go-ethereum/common/hexutil" | ||
| ethrpc "github.com/ethereum/go-ethereum/rpc" | ||
| "github.com/stretchr/testify/require" | ||
|
|
||
| "github.com/sei-protocol/sei-chain/giga/evmonly" | ||
| sdk "github.com/sei-protocol/sei-chain/sei-cosmos/types" | ||
| "github.com/sei-protocol/sei-chain/sei-db/ledger_db/receipt" | ||
| "github.com/sei-protocol/sei-chain/sei-tendermint/rpc/coretypes" | ||
| tmtypes "github.com/sei-protocol/sei-chain/sei-tendermint/types" | ||
| evmtypes "github.com/sei-protocol/sei-chain/x/evm/types" | ||
| ) | ||
|
|
||
| func TestBlockGasRPCsUseLastReceiptAtMatchingHeight(t *testing.T) { | ||
| for _, tc := range []struct { | ||
| name string | ||
| first bool | ||
| lastHeight uint64 | ||
| replayFirst bool | ||
| want uint64 | ||
| }{ | ||
| {name: "last receipt matches", first: true, lastHeight: 9, want: 43_500}, | ||
| {name: "trailing replay of first transaction", first: true, lastHeight: 9, replayFirst: true, want: 43_500}, | ||
| {name: "trailing receipt missing", first: true, want: 21_000}, | ||
| {name: "trailing receipt from earlier block", first: true, lastHeight: 8, want: 21_000}, | ||
| {name: "trailing receipt from later block", first: true, lastHeight: 10, want: 21_000}, | ||
| {name: "no matching receipts", lastHeight: 8}, | ||
| {name: "all receipts missing"}, | ||
| } { | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| tx1, raw1 := testSignedTransaction(t) | ||
| tx2, raw2 := secondSignedTransaction(t) | ||
| store := evmonly.NewMemoryReceiptStore() | ||
| var records []receipt.ReceiptRecord | ||
| if tc.first { | ||
| records = append(records, receipt.ReceiptRecord{TxHash: tx1.Hash(), Receipt: &evmtypes.Receipt{ | ||
| TxHashHex: tx1.Hash().Hex(), BlockNumber: 9, CumulativeGasUsed: 21_000, | ||
| }}) | ||
| } | ||
| if tc.lastHeight != 0 { | ||
| records = append(records, receipt.ReceiptRecord{TxHash: tx2.Hash(), Receipt: &evmtypes.Receipt{ | ||
| TxHashHex: tx2.Hash().Hex(), BlockNumber: tc.lastHeight, TransactionIndex: 1, CumulativeGasUsed: 43_500, | ||
| }}) | ||
| } | ||
| require.NoError(t, store.SetReceipts(sdk.Context{}.WithContext(t.Context()).WithBlockHeight(9), records)) | ||
| trailing := raw2 | ||
| if tc.replayFirst { | ||
| trailing = raw1 | ||
| } | ||
| blockHash := common.HexToHash("0x9") | ||
| block := &coretypes.ResultBlock{ | ||
| BlockID: tmtypes.BlockID{Hash: blockHash.Bytes()}, | ||
| Block: &tmtypes.Block{ | ||
| Header: tmtypes.Header{Height: 9, Time: time.Unix(1_700_000_000, 0)}, | ||
| Data: tmtypes.Data{Txs: tmtypes.Txs{raw1, raw2, trailing}}, | ||
| }, | ||
| } | ||
| backend := fixedGasLimitBackend(t, 100_000, func(context.Context, *coretypes.RequestBlockInfo) (*coretypes.ResultBlock, error) { | ||
| return block, nil | ||
| }) | ||
| backend.blockByHash = func(context.Context, *coretypes.RequestBlockByHash) (*coretypes.ResultBlock, error) { | ||
| return block, nil | ||
| } | ||
| backend.minGasPrice = func() (*big.Int, error) { return big.NewInt(1_000_000_000), nil } | ||
| blocks := &blockAPI{backend: backend, store: store} | ||
| for _, fullTx := range []bool{false, true} { | ||
| byNumber, err := blocks.GetBlockByNumber(t.Context(), 9, fullTx) | ||
| require.NoError(t, err) | ||
| require.Equal(t, hexutil.Uint64(tc.want), byNumber["gasUsed"]) | ||
| byHash, err := blocks.GetBlockByHash(t.Context(), blockHash, fullTx) | ||
| require.NoError(t, err) | ||
| require.Equal(t, hexutil.Uint64(tc.want), byHash["gasUsed"]) | ||
| } | ||
| history, err := (&infoAPI{backend: backend, store: store}).FeeHistory(t.Context(), 1, ethrpc.BlockNumber(9), nil) | ||
| require.NoError(t, err) | ||
| require.Equal(t, []float64{float64(tc.want) / 100_000}, history.GasUsedRatio) | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| type failingGasReceiptStore struct { | ||
| receipt.ReceiptStore | ||
| hash common.Hash | ||
| err error | ||
| } | ||
|
|
||
| func (s failingGasReceiptStore) GetReceipt(ctx sdk.Context, hash common.Hash) (*evmtypes.Receipt, error) { | ||
| if hash == s.hash { | ||
| return nil, s.err | ||
| } | ||
| return s.ReceiptStore.GetReceipt(ctx, hash) | ||
| } | ||
|
|
||
| func TestBlockGasRPCsPropagateReceiptReadErrors(t *testing.T) { | ||
| tx, raw := testSignedTransaction(t) | ||
| _, trailing := secondSignedTransaction(t) | ||
| readErr := errors.New("receipt read failed") | ||
| memory := evmonly.NewMemoryReceiptStore() | ||
| require.NoError(t, memory.SetLatestVersion(9)) | ||
| store := failingGasReceiptStore{ReceiptStore: memory, hash: tx.Hash(), err: readErr} | ||
| block := &coretypes.ResultBlock{Block: &tmtypes.Block{ | ||
| Header: tmtypes.Header{Height: 9, Time: time.Unix(1_700_000_000, 0)}, | ||
| Data: tmtypes.Data{Txs: tmtypes.Txs{raw, trailing}}, | ||
| }} | ||
| backend := fixedGasLimitBackend(t, 100_000, func(context.Context, *coretypes.RequestBlockInfo) (*coretypes.ResultBlock, error) { | ||
| return block, nil | ||
| }) | ||
| backend.minGasPrice = func() (*big.Int, error) { return big.NewInt(1_000_000_000), nil } | ||
| for _, fullTx := range []bool{false, true} { | ||
| _, err := (&blockAPI{backend: backend, store: store}).GetBlockByNumber(t.Context(), 9, fullTx) | ||
| require.ErrorIs(t, err, readErr) | ||
| } | ||
| _, err := (&infoAPI{backend: backend, store: store}).FeeHistory(t.Context(), 1, 9, nil) | ||
| require.ErrorIs(t, err, readErr) | ||
| } | ||
|
|
||
| func TestBlockGasRPCsSkipUnavailableReceiptHeights(t *testing.T) { | ||
| for _, tc := range []struct { | ||
| name string | ||
| latest int64 | ||
| earliest int64 | ||
| }{ | ||
| {name: "pending", latest: 8}, | ||
| {name: "pruned", latest: 10, earliest: 10}, | ||
| } { | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| memory := evmonly.NewMemoryReceiptStore() | ||
| require.NoError(t, memory.SetLatestVersion(tc.latest)) | ||
| require.NoError(t, memory.SetEarliestVersion(tc.earliest)) | ||
| store := &countingReceiptStore{ReceiptStore: memory} | ||
| _, raw := testSignedTransaction(t) | ||
| block := &coretypes.ResultBlock{Block: &tmtypes.Block{ | ||
| Header: tmtypes.Header{Height: 9, Time: time.Unix(1_700_000_000, 0)}, | ||
| Data: tmtypes.Data{Txs: make(tmtypes.Txs, 100)}, | ||
| }} | ||
| for i := range block.Block.Txs { | ||
| block.Block.Txs[i] = raw | ||
| } | ||
| backend := fixedGasLimitBackend(t, 100_000, func(context.Context, *coretypes.RequestBlockInfo) (*coretypes.ResultBlock, error) { | ||
| return block, nil | ||
| }) | ||
| backend.minGasPrice = func() (*big.Int, error) { return big.NewInt(1_000_000_000), nil } | ||
| got, err := (&blockAPI{backend: backend, store: store}).GetBlockByNumber(t.Context(), 9, false) | ||
| require.NoError(t, err) | ||
| require.Equal(t, hexutil.Uint64(0), got["gasUsed"]) | ||
| history, err := (&infoAPI{backend: backend, store: store}).FeeHistory(t.Context(), 1, 9, nil) | ||
| require.NoError(t, err) | ||
| require.Equal(t, []float64{0}, history.GasUsedRatio) | ||
| require.Zero(t, store.reads) | ||
| // Gas lookup also skips decoding transactions for unavailable heights. | ||
| block.Block.Txs[99] = []byte("invalid transaction") | ||
| gas, err := blockGasUsed(t.Context(), store, block) | ||
| require.NoError(t, err) | ||
| require.Zero(t, gas) | ||
| }) | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.