Repository navigation
feat: experimental basePath support when built-from-source - #1411
fallenbagel wants to merge 6 commits into
Conversation
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
* Bugfixes for the experimental basepath feature * Added a redirect to baseURL for the user context * Addressing PR comments * Reverting formatting changes to _app.tsx * Running pnpm format
96a94aa to
65d9efb
Compare
github-actions
Bot
removed
the
merge conflict
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| <select | ||
| onChange={(e) => { | ||
| router.push(e.target.value); | ||
| router.push(getBasedPath(e.target.value)); |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML
| }} | ||
| onBlur={(e) => { | ||
| router.push(e.target.value); | ||
| router.push(getBasedPath(e.target.value)); |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML
Most similar web service software, like the Servarr stack itself, typically has this limitation and requires a restart when changing the path. So IMO that’s fine. |
We're not talking about a restart here. You need to rebuild the app when changing the basePath. |
Ah, sorry, I misunderstood |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
|
Hey, I rebased this PR and updated/simplified it to work on the latest version. Tested it as well, works just fine, didn't notice any errors so far: develop...jkhsjdhjs:seerr:feat-experimental-basepath |
|
Hey, would you please keep this up to date? Serving under a configurable base path is important for users hosting multiple services under one domain, and I would consider it standard expected functionality. Sonarr, Radarr, and Prowlarr all support it natively. Seerr should, too. |
Description
This is to provide experimental basepath support when built from source. It is impossible to provide dynamic basepath support at runtime as nextjs does not support that. So for docker/container image users, they will need to build an image using
docker buildif they want basepath support, after setting the env variables(Wip)
Screenshot (if UI-related)
To-Dos
pnpm buildpnpm i18n:extractIssues Fixed or Closed