feat(ui)!: add collapsible groups, compact overlays and remove charts - #55
Merged
Conversation
Add collapsible form-builder groups and per-group Sidebar V3 expansion. Move hover-copy/query-builder popups outside clipped containers and use compact CDK menus for table command children and selection actions. Refine pill/segmented tab hover styling and align drawer, modal and bottom-sheet header, body and footer padding at 12px 16px. Remove bundled chart components and Chart.js; update consumer migration notes, Showcase examples and all four Angular-major workspaces. BREAKING CHANGE: chart components and exports are removed. Consumers must choose and configure their own chart library. sd-org-chart remains supported. Verification: v19 full suite (5372 tests), focused overlay suite (115 tests), menu regression suite (12 tests), full v19 lint, library and Showcase builds, repository script tests and four-line sync checks passed. Browser checks covered desktop/mobile padding, tab hover, menus, keyboard and focus.
Use CDK disabled state for command menu items so Angular 22 can focus disabled entries while suppressing pointer and keyboard activation. Preserve disabled styling and verify navigation to enabled actions across CDK versions. Validated 12 command/action menu tests on both Angular 19 and Angular 22, scoped ESLint, and four-version synchronization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds per-group collapse controls and makes table menus and overlay spacing more compact. Popups used inside tables escape clipped containers. Chart rendering becomes the consumer's responsibility.
Changes:
collapsible, matchingsd-section; groups expose visibility conditions withoutdisableWhen.Breaking change: consumers using the removed chart components must remove Core UI chart imports and install/configure their chosen chart library.
sd-org-chartremains available. Migration notes are included in CHANGELOG.md and README.npm.md.Local validation: