fix(loading): isolate service overlay CSS from loading buttons - #53
Merged
Conversation
Keep button state/classes and loading reference ownership intact. Prepare the 2.8 release transaction and Console patch upgrade handoff. Verification: 5333 Chrome tests on each Angular line; 206 Showcase tests; full lint; sync; 158 script tests; four build/pack artifacts and strict consumers.
# Conflicts: # CHANGELOG.md # versions/v19/SYNC-STATUS.md # versions/v20/SYNC-STATUS.md # versions/v21/SYNC-STATUS.md # versions/v22/SYNC-STATUS.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
SdLoadingService global
.sd-loadingrules also selected loading buttons, stretching and repositioning header actions. Mark service-owned overlays withdata-sd-loading-overlayand scope overlay/spinner rules to those elements. Preserve button behavior and loading ownership/ref counting.Validation
Release
Prepares suffix 2.8 across Angular 19–22. Includes existing main table/data-state/upload changes; the upload-file API removal remains documented as breaking. No npm publication or release tag. Consumer upgrade instructions and retained patch are in
.sdcorejs/docs/angular/loading-overlay-2.8/.