Validate standalone audio device pairs before opening streams - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The standalone host resolved saved names against every enumerated device without checking whether the device was probed, supported the requested direction, or exposed enough channels. A wrong-direction match could therefore reach stream setup with zero available channels, where subtracting one from the clamped channel index underflowed. Default device IDs could also remain stale after changing audio APIs.
User impact
DirectSound remains the Windows default. Invalid or stale driver/device combinations now fall back to a compatible pair, and the app remains available for configuration when no compatible pair exists instead of attempting to open an invalid stream.
Verification
Examples/IPlugEffect/IPlugEffect.slntargetIPlugEffect-appin Release x64 with the Visual Studio 2022 toolsetgit diff --checkThe hardware-specific failure from sdatkinson/NeuralAmpModelerPlugin#655 could not be reproduced locally without an affected audio-device configuration.
Supersedes #18.