Repository navigation
fix: respect n_top_genes with duplicate variable names - #4409
Open
benjaminkramer510 wants to merge 2 commits into
Open
benjaminkramer510 wants to merge 2 commits into
benjaminkramer510 wants to merge 2 commits into
Conversation
5 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With duplicate variable names,
seurat_v3andseurat_v3_papercan select more thann_top_genesgenes because.locselects every occurrence of a selected name.Select by position instead. The regression test checks that changing gene names leaves the selected genes and statistics unchanged, across both flavors, batching,
inplace, andsubset.Validation:
python -m pytest tests/test_highly_variable_genes.py -q— 237 passed, 1 xfailed, 280 subtests passed. The new test reproduced 39 selected genes instead of 30 before the fix; all 16 cases now pass. Repository hooks pass.LLM usage
LLM or coding agent used: OpenAI GPT-6 via Codex.
If one was used, I, a human, have reviewed, understood and tested every changed line.
Closes
highly_variable_genes(flavor="seurat_v3")flags more thann_top_genesgenes whenvar_namescontain duplicates #4405Tests included.
A release note is included.