Repository navigation
setup.py detection of installed luajit-2 - #1
Merged
3 commits merged intoFeb 11, 2011
Merged
3 commits merged into
3 commits merged into
Conversation
added 3 commits
February 9, 2011 17:56
…her than silently failing, and all prints are pythin3 compatible
Author
|
Ok, I corrected for your suggestions, and then merged your filename changes into what I had done. Hoping that'll do. I think it should apply cleanly and also by python3 compatible. |
Owner
|
Thanks, that looks much better, I'll give it a try. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I pulled out the commands import and rolled my own using subprocess. I also fixed my indents, and changed the mention of README.txt to README.rst. This repo seems to be missing _lupa.c; I'm not sure if that can somehow be generated, or if it just needs to be added, but I tested using the _lupa.c from the 0.18 release.