[ESSSANS] docs: compute reference curve instead of reading it from file - #694
Open
jokasimr wants to merge 3 commits into
Open
[ESSSANS] docs: compute reference curve instead of reading it from file#694jokasimr wants to merge 3 commits into
jokasimr wants to merge 3 commits into
Conversation
github-actions
Bot
changed the title
nvaytet
reviewed
Aug 6, 2026
Comment on lines
+172
to
+174
| The model is the SasView ``poly_gauss_coil`` model with an intensity at zero | ||
| Q of 50, a radius of gyration of 60 angstrom, a polydispersity of 1.02, and | ||
| a background of 0.2. |
Member
There was a problem hiding this comment.
I think the function would be more useful if all the parameters would be values we can tune?
You can still give them the default values you list here, but it would make it useful in case we want a new intensity at Q=0, different Q range, etc..
Member
There was a problem hiding this comment.
Yes, the goal of the issue was to make the computation part of a production code (not just a tutorial helper function), i.e., a graph node computing the model. I don't know if the params should all be workflow params, check with Judidth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #679
I saw that Judith would provide code for this, but I thought it was a bit fun to let codex have a stab at it.
Max absolute difference between curve in file and computed curve is about 1e-8, with max relative difference being about 2e-10.