Add lint check for UI5 controller-extension filename convention #362

Surfaced

2026-06-16 cutover rehearsal — PR #353 fixed BranchAnalyticsHandler.js → .controller.js. The bug was latent since PR #307 (commit fe0b493, 2026-06-12) and went undetected until somebody clicked into a Mission's Object Page on the deployed admin UI.

Class of bug

UI5's sap/ui/core/mvc/ControllerExtension loader requires extension files registered via manifest.json sap.ui.controllerExtensions to follow the standard <Name>.controller.js filename convention. If the file is named <Name>.js, UI5 logs:

GET .../<Name>.controller.js — net::ERR_ABORTED 404
[FUTURE FATAL] Attempt to load Extension Controller ... was not successful

...and the entire Object Page fails to bootstrap (cascading errors). The build doesn't fail; tests don't fail. Only manual browser interaction on the deployed app catches it.

Proposed fix

A pre-build lint that:

1. Scans every app/admin/*/webapp/manifest.json
2. Extracts sap.ui.controllerExtensions[*].controllerName
3. Resolves each module ID to a path
4. Asserts that <path>.controller.js exists (NOT <path>.js)
5. Fails the lint with a file:line ref to the offending manifest entry

Could live as:

• A new file under scripts/lint-ui5-controller-extensions.ts, or
• An assertion inside the existing postbuild:apps step (scripts/check-build-collisions.ts is precedent)

Effort

Small — single-file lint, run from the standard build pipeline. ~30 lines.

Where to wire

Either:

• prebuild script in app/admin-shell/package.json, or
• postbuild:apps (existing entry point in root package.json)

Either keeps it inside the routine npm run build:all flow.