Repository navigation
Fix lint and test failures in PR #3 - #6
Merged
sansari merged 4 commits intoFeb 17, 2026
Merged
Conversation
- Fix RuboCop Layout/SpaceInsideArrayLiteralBrackets errors by removing spaces inside array brackets - Fix test failures by using dig() to safely access VAPID credentials that may not be set in test environment Co-authored-by: sansari <105090+sansari@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add Mark Done button to tasks on dashboard and detail page
Fix lint and test failures in PR #3
Feb 17, 2026
Owner
|
@copilot lint still failing |
- Add spaces inside array brackets per rubocop-rails-omakase style guide - Changed [:foo] to [ :foo ] in 4 controller files Co-authored-by: sansari <105090+sansari@users.noreply.github.com>
Contributor
Author
I've fixed the lint errors in commit b436197. My initial fix was incorrect - I removed spaces when I should have added them. The rubocop-rails-omakase style guide requires spaces INSIDE array brackets: Fixed in:
The CI workflow is waiting for approval to run. Once approved, the lint job should pass. |
Owner
|
@copilot its still failing... just disable that rule and fix the end of file line |
…ty line - Disable Layout/SpaceInsideArrayLiteralBrackets in .rubocop.yml - Remove extra empty line before class end in maintenance_task_test.rb Co-authored-by: sansari <105090+sansari@users.noreply.github.com>
Contributor
Author
sansari
approved these changes
Feb 17, 2026
sansari
marked this pull request as ready for review
February 17, 2026 04:06
sansari
merged commit Feb 17, 2026
727b10b
into
claude/review-production-access-raAQq
5 checks passed
sansari
added a commit
that referenced
this pull request
Jun 25, 2026
sansari
added a commit
that referenced
this pull request
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #3 failed CI due to RuboCop violations and test errors caused by missing credentials in the test environment.
Changes
Test failures: Changed
Rails.application.credentials.vapid[:public_key]tocredentials.dig(:vapid, :public_key)inapplication.html.erbto handle missing VAPID credentials gracefully in testsLint violations:
Layout/SpaceInsideArrayLiteralBracketsrule in.rubocop.ymlto allow flexible array bracket spacingLayout/EmptyLinesAroundClassBodyerror by removing extra empty line before class end intest/models/maintenance_task_test.rb💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.