Theming 9/11: Stop the root views from building UiTheme - #1542
Open
DavDo wants to merge 3 commits into
Open
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Nine root views (chat, call, message center + confirmation, survey, web browser, visitor code, chat head) resolved a UiTheme snapshot on top of layouts that already read the same glia* attributes. Delete that second application everywhere the layout already carries the value, and resolve the handful of attributes a layout genuinely cannot express (a Lottie tint, a merge-root background, a per-state icon, a typeface) straight from the composed theme instead. ChatHeadConfiguration is deleted along with it - ChatHeadView was its last reader - so view/configuration/ now only holds Phase 8's remaining classes.
UploadAttachmentAdapter fell back to hardcoded glia_primary_color / glia_normal_color literals whenever there was no JSON theme override, instead of the ?attr/glia* value the layout itself already resolves. Under the default theme this looked identical to the customized case, so a legacy overlay or GliaTheme brand-colour change silently skipped the file upload progress bar, its type-indicator badge, and the title text while every other themed surface picked it up.
Dokka cannot resolve the ColorStateList link, and the API-docs CI step fails on any warning.
DavDo
force-pushed
the
feature/MOB-5045-theme-migration-phase_9
branch
from
August 13, 2026 11:28
19bda64 to
a143b9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira issue:
https://glia.atlassian.net/browse/MOB-5045
What was solved?
Part 9/11. The root views (
ChatView,CallView,MessageCenterView,MessageView,ConfirmationScreenView,SurveyView,WebBrowserView,VisitorCodeView,ChatHeadView) stop buildingUiTheme— after PRs 5–8 nothing downstream consumed it. The few values with no layout to fall back on (Lottie typing-indicator colour,<merge>root background, bind-time call-button icons) resolve attributes directly. Constructors collapse to@JvmOverloadswithdefStyleAttr = 0;ChatHeadConfigurationdeleted with its last reader.Additional info:
Screenshots:
No visual change by design —
./gradlew widgetssdk:verifySnapshotspasses with every pre-existing golden byte-identical.