Repository navigation
CAppMainWnd::TrackPopupMenuを追加する - #2880
Merged
berryzplus merged 2 commits intoNov 19, 2026
Merged
Conversation
berryzplus
commented
Nov 19, 2026
berryzplus
left a comment
Contributor
Author
There was a problem hiding this comment.
Duplication Code 指標で引っかかっている。
CControlTray から抜き出した部分が「まったく同じ」であるため。
CControlTray から ポップアップメニューを表示する には 共通処理 が存在していて、
そこを対策してやればいいんだろうけど。
モック可能なポップアップメニュー表示機能をメインウィンドウの機能として抜き出し定義する。
berryzplus
force-pushed
the
feature/add_track_popup_menu
branch
from
November 19, 2026 03:08
ad5091c to
f81886b
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PR対象
カテゴリ
PR の背景
このあたりをテストするために必要。
sakura/sakura_core/view/CEditView_Mouse.cpp
Lines 2140 to 2145 in e4e4ff3
導入すればここを書き替えてテスト可能にできる。
sakura/sakura_core/view/CEditView_Mouse.cpp
Lines 2129 to 2132 in e4e4ff3
仕様・動作説明
本件、勝手にやります。
PR の影響範囲
テスト内容
関連 issue, PR
参考資料