Skip to content

fix: race condition in warmup tests - #481

Merged
aawsome merged 1 commit into
rustic-rs:mainfrom
philipmw:warmup-tests
Feb 23, 2026
Merged

aawsome merged 1 commit into
rustic-rs:mainfrom
philipmw:warmup-tests

Conversation

@philipmw

@philipmw philipmw commented Feb 22, 2026 •

Copy link
Copy Markdown
Contributor

There is a race condition caused by unit tests creating a script on the filesystem and trying to execute it too fast since creation; the operating system is not allowing execution yet. We don't know how long to wait, but waiting longer will solve it.

closes #480

@aawsome aawsome changed the title fix: race condition in warmup tests (#480) fix: race condition in warmup tests Feb 22, 2026
Comment thread crates/core/src/repository/warm_up.rs Resolved
Comment thread crates/core/src/repository/warm_up.rs Resolved
There is a race condition caused by unit tests creating a script on the filesystem
and trying to execute it too fast since creation; the operating system is not
allowing execution yet. We don't know how long to wait, but waiting longer will
solve it.

@aawsome aawsome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @philipmw

@aawsome
aawsome enabled auto-merge February 23, 2026 09:04
@aawsome
aawsome added this pull request to the merge queue Feb 23, 2026
Merged via the queue into rustic-rs:main with commit 31eda1e Feb 23, 2026
27 checks passed
@rustic-release-plz rustic-release-plz Bot mentioned this pull request Feb 23, 2026
github-merge-queue Bot pushed a commit that referenced this pull request Mar 4, 2026
## 🤖 New release

* `rustic_core`: 0.10.0 -> 0.10.1 (✓ API compatible changes)
* `rustic_backend`: 0.6.0 -> 0.6.1 (✓ API compatible changes)
* `rustic_testing`: 0.4.0 -> 0.4.1 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

## `rustic_core`

<blockquote>

##
[0.10.1](rustic_core-v0.10.0...rustic_core-v0.10.1)
- 2026-03-04

### Added

- Add methods for repairing hot/cold repositories
([#255](#255))

### Fixed

- use rclone url as-is for rclone command
([#485](#485))
- Add information about to_delete to check errors
([#484](#484))
- race condition in warmup tests
([#481](#481))
- only call warm-up/wait if #ids > 0
([#483](#483))
- show type/id for crypto errors
([#482](#482))
- ignore non-id files when listing
([#479](#479))
- sort blobs before repacking
([#478](#478))
- tag options in rewrite don't conflict with each other
([#476](#476))

### Other

- update dependencies
([#486](#486))
</blockquote>

## `rustic_backend`

<blockquote>

##
[0.6.1](rustic_backend-v0.6.0...rustic_backend-v0.6.1)
- 2026-03-04

### Fixed

- use rclone url as-is for rclone command
([#485](#485))
- ignore non-id files when listing
([#479](#479))

### Other

- update dependencies
([#486](#486))
</blockquote>

## `rustic_testing`

<blockquote>

##
[0.4.1](rustic_testing-v0.4.0...rustic_testing-v0.4.1)
- 2026-03-04

### Added

- Add methods for repairing hot/cold repositories
([#255](#255))

### Other

- update dependencies
([#486](#486))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

Co-authored-by: rustic-release-plz[bot] <182542030+rustic-release-plz[bot]@users.noreply.github.com>
@philipmw
philipmw deleted the warmup-tests branch June 22, 2026 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

warm-up tests sometimes fail in CI-pipeline

2 participants