Skip to content

fix(repository): use KeyId in delete_key() - #410

Merged
aawsome merged 2 commits into
mainfrom
fix-delete-key
Jun 13, 2025
Merged

aawsome merged 2 commits into
mainfrom
fix-delete-key

Conversation

@aawsome

@aawsome aawsome commented Jun 13, 2025 •

Copy link
Copy Markdown
Member

delete_key used a str and searched for a matching KeyId. Now this methods allows to specify a KeyId directly.
In #411 there is find_ids which can be used to search for matching Ids.

@codecov

codecov Bot commented Jun 13, 2025 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 42.3%. Comparing base (f5ab8c7) to head (cb22219).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/repository.rs 33.3% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/core/src/repository.rs 42.9% <33.3%> (-0.5%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aawsome
aawsome merged commit f7cd468 into main Jun 13, 2025
@aawsome
aawsome deleted the fix-delete-key branch June 13, 2025 09:20
@rustic-release-plz rustic-release-plz Bot mentioned this pull request Jun 13, 2025
@rustic-release-plz rustic-release-plz Bot mentioned this pull request Jun 29, 2025
github-merge-queue Bot pushed a commit that referenced this pull request Sep 12, 2025
## 🤖 New release
* `rustic_backend`: 0.5.2 -> 0.5.3 (✓ API compatible changes)
* `rustic_core`: 0.7.3 -> 0.8.0 (✓ API compatible changes)
* `rustic_testing`: 0.3.2 -> 0.3.3 (✓ API compatible changes)
* `rustic_config`: 0.2.2 -> 0.2.3 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

## `rustic_backend`
<blockquote>

##
[0.5.3](rustic_backend-v0.5.2...rustic_backend-v0.5.3)
- 2025-09-12

### Fixed

- fix clippy lints
([#407](#407))
- *(deps)* lock file maintenance rust dependencies (#389)

### Other

- update dependencies
([#428](#428))
- update to 2024 edition and fix clippy lints (#399)
- update dependencies and fix clippy lints / remove opendal::ftp support
(#405)
- Update opendal to 0.51.0 (#391)
</blockquote>

## `rustic_core`
<blockquote>

##
[0.8.0](rustic_core-v0.7.3...rustic_core-v0.8.0)
- 2025-09-12

### Added

- Add fixed size chunking and allow fine-tune of rabin chunking (#422)
- Add env argument to the run function of command input (#420)
- Show processed file when chunker gives an error (#421)
- snapshots can be identified with latest~N (N >= 0) (#416)
- expose Tree::serialize method
- *(repository)* add progress_bars method
- *(repository)* Add find_ids and stream_files_list (#411)
- *(commands)* Add delete_unchanged option to forget (#386)
- *(commands)* [**breaking**] rename backup skip_identical_parent to
skip_if_unchanged (#387)
- *(warmup)* [**breaking**] Add warmup wait command (#379)

### Fixed

- Make example for time format even more explicit (#425)
- Add example for time format (#424)
- fix clippy lints
([#423](#423))
- [**breaking**] Allow to unset append-only mode (#414)
- improve handling of u32 conversions (#412)
- *(repository)* use KeyId in delete_key() (#410)
- Fix repair index (#406)
- Allow to request identical snapshot multiple times (#408)
- fix clippy lints
([#407](#407))
- fix clippy lints
- [**breaking**] Don't panic when reading empty files (#381)

### Other

- update dependencies
([#428](#428))
- Add SnapshotFile::from_strs() to search for multiple snapshots
([#419](#419))
- *(repository)* [**breaking**] Add more control over used keys (#383)
- update to 2024 edition and fix clippy lints (#399)
- update dependencies and fix clippy lints / remove opendal::ftp support
(#405)
</blockquote>

## `rustic_testing`
<blockquote>

##
[0.3.3](rustic_testing-v0.3.2...rustic_testing-v0.3.3)
- 2025-09-12

### Other

- update to 2024 edition and fix clippy lints (#399)
- update dependencies and fix clippy lints / remove opendal::ftp support
(#405)
</blockquote>

## `rustic_config`
<blockquote>

##
[0.2.3](rustic_config-v0.2.2...rustic_config-v0.2.3)
- 2025-09-12

### Other

- update to 2024 edition and fix clippy lints (#399)
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

Co-authored-by: rustic-release-plz[bot] <182542030+rustic-release-plz[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant