Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1940
Problem
copylogs each target's error ([ERROR] error copying to target: …), goes on with the next target, and then exits 0. Scripts and schedulers can't tell that nothing was copied: an offline target, a target with another chunker, a target that doesn't exist, or rustic-rs/rustic_core#601 (copy --initbetween plain and hot/cold repositories).Fix
Like
backupwith several snapshots ("Not all snapshots were generated successfully!"),copystill tries every target, then returns an error if any of them failed:The exit code is then non-zero. When all targets succeed, nothing changes.
Tests
test_copy_to_failing_target_fails(intests/backup_restore.rs) backs up, then copies to a target profile whose repository doesn't exist. Onmainthe copy exits 0 and the test fails ("Unexpected success",code=0). With this change it fails as expected and the test passes. The other tests inbackup_restore.rsstill pass.