Skip to content

fix: correct mount options #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aawsome merged 1 commit into from
Feb 24, 2026
Merged

fix: correct mount options #1685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/commands/mount.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ use anyhow::{Result, bail};
use clap::Parser;
use conflate::{Merge, MergeFrom};
use fuse_mt::{FuseMT, mount};
use log::info;
use rustic_core::vfs::{FilePolicy, IdenticalSnapshot, Latest, Vfs};
use std::{ffi::OsStr, path::PathBuf};

Expand All @@ -35,7 +36,7 @@ pub struct MountCmd {
#[merge(strategy=conflate::option::overwrite_none)]
time_template: Option<String>,

/// Don't allow other users to access the mount point
/// Don't allow other users to access the mount point (else options allow_other,default_permissions are set)
#[clap(short, long)]
#[merge(strategy=conflate::bool::overwrite_false)]
exclusive: bool,
Expand Down Expand Up @@ -106,7 +107,7 @@ impl MountCmd {
Self {
path_template: Some(String::from("[{hostname}]/[{label}]/{time}")),
time_template: Some(String::from("%Y-%m-%d_%H-%M-%S")),
options: vec![String::from("kernel_cache")],
options: Vec::new(),
..Default::default()
}
}
Expand Down Expand Up @@ -174,8 +175,12 @@ impl MountCmd {
// join options into a single comma-delimited string and prepent "-o "
// this should be parsed just fine by fuser, here
// https://github.com/cberner/fuser/blob/9f6ced73a36f1d99846e28be9c5e4903939ee9d5/src/mnt/mount_options.rs#L157
let opt_string = format!("-o {}", mount_options.join(","));
let opt_string = format!("-o{}", mount_options.join(","));

info!(
"mounting {}, press Ctrl-C to cancel...",
mount_point.display()
);
mount(fs, mount_point, &[OsStr::new(&opt_string)])?;

Ok(())
Expand Down
Loading