Skip to content

fix: rename OPENDAL_HOT_*/COLD_* to OPENDALHOT_*/COLD_* - #1393

Merged
aawsome merged 7 commits into
mainfrom
fix-opendal-env
Apr 19, 2025
Merged

fix: rename OPENDAL_HOT_*/COLD_* to OPENDALHOT_*/COLD_*#1393
aawsome merged 7 commits into
mainfrom
fix-opendal-env

Conversation

@aawsome

@aawsome aawsome commented Jan 2, 2025

Copy link
Copy Markdown
Member

#1392 was unfortunately ambiguous. IMO the better option to solve #1391 is to use OPENDALHOT_* and OPENDALCOLD_* env variables.

@simonsan

simonsan commented Jan 3, 2025

Copy link
Copy Markdown
Contributor

Wouldn't it be more consistent to use RUSTIC_OPENDAL_* to make it less ambigious and also people can relate the env var to rustic?

@aawsome

aawsome commented Jan 26, 2025

Copy link
Copy Markdown
Member Author

It is actually a bit complicated. The opendal project also uses OPENDAL_* variables in their own CLI (I think they call it oli), so it might be beneficial to also use those. Besides this, you are right that most env variables we use start with RUSTIC_* - however, these are all the ones where we have a CLI option which is replaced by this. Here we define options which are not exposed as CLI parametes, but only within the config profile..

Anyway, the amiguity if OPENDA_HOT_XXX=YYY should be interpreted as the parameter xxx=yyy for a hot repo repo (which we want here) or as hot_xxx=yyy for hot/cold part (which is what is used without this PR) must be solved, IMO.

@aawsome
aawsome merged commit 2c24954 into main Apr 19, 2025
@aawsome
aawsome deleted the fix-opendal-env branch April 19, 2025 05:21
@rustic-release-plz rustic-release-plz Bot mentioned this pull request Jul 23, 2025
Closed
@rustic-release-plz rustic-release-plz Bot mentioned this pull request Aug 31, 2025
Merged
github-merge-queue Bot pushed a commit that referenced this pull request Sep 12, 2025
@rustic-release-plz @aawsome
chore: release v0.10.0 (#1547)
e54c1cb 
## 🤖 New release

* `rustic-rs`: 0.9.5 -> 0.10.0 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.10.0](v0.9.5...v0.10.0) -
2025-09-12

### Added

- Add --name option to select snapshot(s) from config to backup
([#1531](#1531))
- *(commands)* make group_by a global option
([#1545](#1545))
- Add environment variables to the hooks
([#1518](#1518))
- *(commands)* copy checks all chunker constellations
([#1530](#1530))
- *(interactive)* Add possibility to change snapshot hostname
([#1498](#1498))
- OpenTelemetry Protocol support for metrics
([#1473](#1473))
- *(interactive)* Reduce memory consumption of summary
([#1489](#1489))
- *(interactive)* remember summary when switching snapshot/ls/diff views
([#1485](#1485))
- *(interactive)* [**breaking**] Add interactive diff / overwork diff
output ([#1480](#1480))
- *(interactive)* ls: Add options to compute cumulative statistics
([#1479](#1479))
- *(commands)* Add missing key subcommands
([#1385](#1385))
- *(commands)* [**breaking**] Fine-tune output for snapshots command
when no grouping is given
([#1375](#1375))
- *(diff)* Use local PATH1 as PATH2 if no new snapshot/path is given
([#1474](#1474))
- *(commands)* [**breaking**] Extend logging
([#1463](#1463))
- push prometheus metrics to pushgateway on-demand
([#1404](#1404))
- Allow to use OPENDAL_HOT_* and OPENDAL_COLD_* env variables
([#1392](#1392))

### Fixed

- sanitize paths after run-before hook
([#1549](#1549))
- Handle dry-run for all commands
([#1546](#1546))
- fix clippy lints
([#1533](#1533))
- cargo update openssh-sftp-client
([#1510](#1510))
- Don't allow wrong commands in front of valid ones
([#1464](#1464))
- fix clippy lints
- rename OPENDAL_HOT_*/COLD_* to OPENDALHOT_*/COLD_*
([#1393](#1393))
- fix clippy lint
- *(commands)* remove SIGPIPE default handler
([#1431](#1431))
- fix clippy lints
- *(config)* set a non-zero default progress interval for progress
options ([#1378](#1378))

### Other

- update dependencies
([#1556](#1556))
- *(deps)* bump tracing-subscriber from 0.3.19 to 0.3.20
([#1544](#1544))
- [**breaking**] Remove --filter-fn from default
([#1482](#1482))
- update rustic_core
([#1541](#1541))
- update rustic_core
([#1519](#1519))
- *(config)* Correct the `exclude-if-present` option descritption
([#1506](#1506))
- update to latest rustic_core
([#1491](#1491))
- clippy lints
- Use rustic_core development version
([#1476](#1476))
- code formatting
- adapt to latest rustic_core
([#1456](#1456))
- use 2024 edition
([#1453](#1453))
- update prometheus version
- dependency updates
- *(deps)* bump zip from 2.2.1 to 2.3.0
([#1432](#1432))
- *(deps)* bump ring from 0.17.8 to 0.17.13
([#1424](#1424))
- Add Homebrew instructions
([#1416](#1416))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

---------

Co-authored-by: rustic-release-plz[bot] <182542030+rustic-release-plz[bot]@users.noreply.github.com>
Co-authored-by: Alexander Weiss <alex@weissfam.de>
@botantony botantony mentioned this pull request Sep 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aawsome @simonsan