Skip to content

Hide documentation of rand_wasm_bindgen_test crate - #914

Closed
vks wants to merge 1 commit into
rust-random:masterfrom
vks:hide-bindgen
Closed

vks wants to merge 1 commit into
rust-random:masterfrom
vks:hide-bindgen

Conversation

@vks

@vks vks commented Nov 29, 2019

Copy link
Copy Markdown
Contributor

Fixes #913.

@vks
vks requested a review from dhardy November 29, 2019 14:28
@dhardy

dhardy commented Nov 29, 2019

Copy link
Copy Markdown
Member

Hmm:

 Documenting rand_wasm_bindgen_test v0.1.0 (/home/travis/build/rust-random/rand/tests/wasm_bindgen)

error: couldn't generate documentation: No such file or directory (os error 2)

@dhardy

dhardy commented Nov 29, 2019

Copy link
Copy Markdown
Member

I guess this is a side-effect of using --all in

cargo doc --no-deps --all --all-features

It is possible to list crates manually (-p rand -p rand_core ...) but I'm not keen on this. Perhaps we should just put up with the status quo?

@vks

vks commented Nov 29, 2019

Copy link
Copy Markdown
Contributor Author

Some alternatives to try are #![doc(html_no_source)] and #[doc(masked)] (unstable).

@dhardy

dhardy commented Nov 30, 2019

Copy link
Copy Markdown
Member

I tried both locally; in each case the documentation was still generated (no apparent effect). (Using #![doc(hidden)] locally also failed the bulid.)

@vks

vks commented Nov 30, 2019

Copy link
Copy Markdown
Contributor Author

I guess that means the only remaining option is to list the crates individually.

@vks

vks commented Dec 9, 2019

Copy link
Copy Markdown
Contributor Author

I'm closing this, since it seems like we cannot fix this by changing the source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crate documentation lists rand_wasm_bindgen_test crate

2 participants