Skip to content

Fix build errors on nightly (alloc crate changes) - #545

Merged
dhardy merged 2 commits into
rust-random:masterfrom
dhardy:nightly
Jul 11, 2018
Merged

dhardy merged 2 commits into
rust-random:masterfrom
dhardy:nightly

Conversation

@dhardy

@dhardy dhardy commented Jul 10, 2018

Copy link
Copy Markdown
Member

No description provided.

@dhardy

dhardy commented Jul 10, 2018

Copy link
Copy Markdown
Member Author

Aside from the import syntax not working on older compilers, it seems from_bits was not available in libcore before 1.25.0 (strangely, the CI test doesn't seem to pick this up, but local builds do).

Is it time to increase the minimum compiler version? It would fix these two issues.

@dhardy

dhardy commented Jul 11, 2018

Copy link
Copy Markdown
Member Author

No, raising the version to 1.25.0 does not fix this (see rust-lang/rust#46931 (comment)).

@dhardy
dhardy merged commit 74c68bf into rust-random:master Jul 11, 2018
@dhardy
dhardy deleted the nightly branch July 11, 2018 09:57
@dhardy dhardy mentioned this pull request Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant