Skip to content

Failure when using num_derive on latest nightly #240

Closed
Closed
Failure when using num_derive on latest nightly#240
Assignees
hauleth

Description

@est31
est31
opened on Nov 16, 2016

To reproduce, run cargo test on the num/derive subdir, you will get lots of "a type named ... has already been defined in this module".

I can reproduce with 1.15.0-nightly (0ed951993 2016-11-14).

This change in behaviour was probably caused by rust-lang/rust#37614, but its actually wanted behaviour.

Basically the proc macro isn't expected anymore to output the item itself, only the impl's.

Activity

  1. hauleth commented on Nov 16, 2016

    @hauleth
    hauleth
    on Nov 16, 2016
    Member

    Will investigate.

  2. hauleth
    self-assigned this
    on Nov 16, 2016

  3. est31 commented on Nov 27, 2016

    @est31
    est31
    on Nov 27, 2016
    ContributorAuthor

    @hauleth any news?

  4. hauleth
    added a commit that references this issue on Nov 27, 2016

    fix(num_derive): code duplication error

    20243f5

  5. hauleth commented on Nov 27, 2016

    @hauleth
    hauleth
    on Nov 27, 2016
    Member

    @est31 #242

  6. cuviper
    closed this as completedin #242on Nov 28, 2016
  7. est31
    added a commit that references this issue on Jan 28, 2017

    Update num-derive to work with latest rustc

    a9f7069
  8. remexre
    added a commit that references this issue on Jun 1, 2017

    Merge pull request rust-num#240 from Kroisse/from-iterator-for-map

    9984a31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions