Skip to content

Add intrinsics for the new AMX target features - #1846

Merged
Amanieu merged 3 commits into
rust-lang:masterfrom
sayantn:new-amx-intrinsics
Nov 4, 2025
Merged

Amanieu merged 3 commits into
rust-lang:masterfrom
sayantn:new-amx-intrinsics

Conversation

@sayantn

@sayantn sayantn commented Jul 4, 2025 •

Copy link
Copy Markdown
Contributor

WIP

  • Tests
  • Links to Intrinsics Guide (not updated yet, probably will be after DiamondRapids is released). Temporarily patched stdarch-verify to make it work

This was sitting around for quite some time, I didn't open the PR because it's still not in the Intrinsics Guide

@sayantn

sayantn commented Aug 28, 2025

Copy link
Copy Markdown
Contributor Author

@Amanieu should I go ahead and open this PR (with some modifications in the stdarch_verify logic to get around the fact that these aren't in the Intrinsics Guide yet)?

@Amanieu

Amanieu commented Aug 28, 2025

Copy link
Copy Markdown
Member

It's fine to add these, but please add a FIXME: since these aren't in the XML they are not being tested.

@sayantn

sayantn commented Aug 28, 2025

Copy link
Copy Markdown
Contributor Author

Just to be clear, I will be adding the normal tests (I'm just being lazy), only thing that won't be tested is the presence of links to the Intel docs

@sayantn
sayantn force-pushed the new-amx-intrinsics branch from e6a3905 to 97dc3f6 Compare November 1, 2025 00:34
@sayantn
sayantn force-pushed the new-amx-intrinsics branch from 97dc3f6 to e5857cd Compare November 1, 2025 02:23
@sayantn
sayantn marked this pull request as ready for review November 1, 2025 02:33
@rustbot

rustbot commented Nov 1, 2025

Copy link
Copy Markdown
Collaborator

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@sayantn

sayantn commented Nov 3, 2025

Copy link
Copy Markdown
Contributor Author

Finally got around to finishing this lol

@Amanieu
Amanieu added this pull request to the merge queue Nov 4, 2025
Merged via the queue into rust-lang:master with commit 09a537e Nov 4, 2025
73 checks passed
@sayantn
sayantn deleted the new-amx-intrinsics branch November 8, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants