Repository navigation
Unsoundness in <SockRef as From<&AsRawFd>>::from #229
Description
You can do something like:
let sock = socket2::SockRef::from(&-1);
assert!(Some(sock).is_none());With the changes in #222
Activity
Thomasdezeeuw commentedon May 3, 2021
This is the same problem as being discussed in #229,
SockRef::fromneeds to ensure theRawFdis valid, but currently doesn't.Thomasdezeeuw commentedon May 3, 2021
Whoops I meant #218.
coolreader18 commentedon May 3, 2021
Ah, sorry about that, shoulda checked.
coolreader18 commentedon May 3, 2021
Oh, wait, I'll add this to that discussion, but this is actually unsound language-wise, not just questionably unsafe/non-private - because of the niche optimization from #222, you can create an invalid value in safe code.
Thomasdezeeuw commentedon May 3, 2021
You're right using
-1is even worse, but as #222 is talking about a redesign I though it best to not have two concurrent threads talking about the same thing. But this is definitely blocking a v0.4.1 release (which would include #222).