Skip to content

Unpack progress - #4594

Merged
djc merged 2 commits into
mainfrom
unpack-progress
Nov 19, 2025
Merged

djc merged 2 commits into
mainfrom
unpack-progress

Conversation

@djc

@djc djc commented Nov 11, 2025 •

Copy link
Copy Markdown
Contributor

cc @FranciscoTGouveia

unpack-progress.mov

@FranciscoTGouveia

FranciscoTGouveia commented Nov 13, 2025 •

Copy link
Copy Markdown
Contributor

After testing the changes, it seems that the ticking speed for the unpacking phase is so high that it feels a bit disconcerting.
Would it be possible to slow it down?

Moreover, I would like to ask whether this change is a step toward achieving concurrent downloads & installs (without spawning an additional thread).
If so, I believe the issue where progress bars stop updating during installation (as discussed in #4570) remains, and I do not think that this will help in facilitating that -- I might be overlooking something here.
Even though downloads continue in the background, the blocking install call never yields, so the progress bars never get the chance to update during installation.

I think that making install async is ultimately the only way to avoid the spawning of an additional thread.

@rami3l

rami3l commented Nov 13, 2025 •

Copy link
Copy Markdown
Member

@FranciscoTGouveia In the current stable version we actually have progress reporting for unpacking as well, however it's behind a 1-second timeout so no one actually sees it except for the docs component.

Thus, I think your concern is reasonable, and even though it's probably great for @djc to restore that behavior here, it might be worth it to make it closer to the original in terms of lowering the number of ticks indeed.

@rami3l rami3l left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested locally. The code looks okay but I share @FranciscoTGouveia's concern: it looks like the tick frequency is way too high...

@djc
djc marked this pull request as ready for review November 18, 2025 11:18
@djc

djc commented Nov 18, 2025 •

Copy link
Copy Markdown
Contributor Author

Changed it to display a progress bar while unpacking. See the movie in the PR description (which also includes #4602).

@djc
djc added this pull request to the merge queue Nov 18, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 18, 2025
@djc
djc added this pull request to the merge queue Nov 19, 2025
Merged via the queue into main with commit 4ae2012 Nov 19, 2025
29 checks passed
@djc
djc deleted the unpack-progress branch November 19, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants