Skip to content

refactor(installation): extract installation of a component into a separate function - #4545

Merged
djc merged 1 commit into
rust-lang:mainfrom
rami3l:refactor/prep-install-after-download
Oct 19, 2025
Merged

djc merged 1 commit into
rust-lang:mainfrom
rami3l:refactor/prep-install-after-download

Conversation

@rami3l

@rami3l rami3l commented Oct 18, 2025 •

Copy link
Copy Markdown
Member

Cherry-picked from #4471, in response to #4471 (comment).

cc @FranciscoTGouveia

@rami3l
rami3l requested a review from djc October 18, 2025 15:07
@rami3l rami3l changed the title fix(installation): extract installation of a component into a separate function refactor(installation): extract installation of a component into a separate function Oct 18, 2025
@rami3l
rami3l force-pushed the refactor/prep-install-after-download branch from cc0c97b to bb331a7 Compare October 18, 2025 15:07
@djc

djc commented Oct 18, 2025 •

Copy link
Copy Markdown
Contributor

Cherry-picked from #4471, in response to #4471 (comment).

See also the feedback in that PR about attaching this to ComponentBinary instead.

@rami3l
rami3l force-pushed the refactor/prep-install-after-download branch from bb331a7 to e277a27 Compare October 19, 2025 02:10
…parate function

Co-authored-by: rami3l <rami3l@outlook.com>
@rami3l
rami3l force-pushed the refactor/prep-install-after-download branch from e277a27 to 0de329e Compare October 19, 2025 02:12
@djc
djc added this pull request to the merge queue Oct 19, 2025
Merged via the queue into rust-lang:main with commit 09df8be Oct 19, 2025
29 checks passed
@rami3l
rami3l deleted the refactor/prep-install-after-download branch May 3, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants