Skip to content

Remove more Notification variants (part 3) - #4510

Merged
djc merged 19 commits into
mainfrom
notifications-3
Oct 10, 2025
Merged

Remove more Notification variants (part 3)#4510
djc merged 19 commits into
mainfrom
notifications-3

Conversation

@djc

@djc djc commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

@djc
djc requested review from ChrisDenton and rami3l October 2, 2025 08:45
@djc
djc force-pushed the notifications-3 branch from b444522 to 47d39ac Compare October 10, 2025 12:44
@rami3l rami3l self-assigned this Oct 10, 2025
rami3l
rami3l approved these changes Oct 10, 2025
View reviewed changes

@rami3l rami3l left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the effort to simplify all this :)

djc added 19 commits October 10, 2025 17:32
@djc
notifications: use human-friendly log format for path canonicalization
dc5ff3d
@djc
notifications: use human-friendly log format for retrying renames
205ae41
@djc
notifications: use human-friendly log format for directory deletions
488c78e
@djc
notifications: use human-friendly log format for temp file deletions
44f37aa
@djc
notifications: log directly when setting overrides
d91511a
@djc
notifications: log directly when setting profile
c132bb1
@djc
notifications: log directly when setting auto-self-update mode
5424877
@djc
notifications: log directly when looking for toolchains
9860966
@djc
notifications: log directly when using existing toolchains
d20aad5
@djc
notifications: log the toolchain directory directly
2bf043b
@djc
notifications: log directly when installing toolchains
ec5f760
@djc
notifications: log directly when toolchain has been installed
53ebff7
@djc
notifications: log directly when toolchain is up to date
e6ef727
@djc
notifications: log directly when uninstalling toolchains
fa4cbde
@djc
notifications: log directly when upgrading metadata version
73ae72d
@djc
notifications: log directly when metadata upgrade is not needed
3ab64db
@djc
notifications: log directly when reading metadata version
16928e8
@djc
notifications: log directly on metadata upgrades that remove toolchains
6bfa3f7
@djc
notifications: log directly on duplicate toolchain files
6a313cd
@djc
djc force-pushed the notifications-3 branch from 47d39ac to 6a313cd Compare October 10, 2025 15:37
@djc
djc enabled auto-merge October 10, 2025 15:48
@djc
djc added this pull request to the merge queue Oct 10, 2025
Merged via the queue into main with commit 30ee45b Oct 10, 2025
29 checks passed
@djc
djc deleted the notifications-3 branch October 10, 2025 16:27
@djc djc mentioned this pull request Oct 11, 2025
Merged
@rami3l rami3l mentioned this pull request Sep 3, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rami3l rami3l rami3l approved these changes
@ChrisDenton ChrisDenton Awaiting requested review from ChrisDenton

Assignees

@rami3l rami3l

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@djc @rami3l