Repository navigation
feat: adjust default concurrent download count - #4474
Merged
Merged
Conversation
djc
approved these changes
Sep 8, 2025
rami3l
force-pushed
the
feat/concurrent-download-default
branch
3 times, most recently
from
September 8, 2025 13:39
f6efb6d to
2fc451f
Compare
rami3l
commented
Sep 8, 2025
|
|
||
| // Ensure that `.buffered()` is never called with 0 as this will cause a hang. | ||
| // See: https://github.com/rust-lang/futures-rs/pull/1194#discussion_r209501774 | ||
| if num_channels > 0 { |
Member
Author
There was a problem hiding this comment.
This will actually hang when .concurrent_downloads() returns non-zero but channels_len is zero. This PR happens to help manifest this regression (the invariant stated in the comment above has been broken since #4455, my apologies for not finding it out earlier).
rami3l
enabled auto-merge
September 8, 2025 13:53
rami3l
disabled auto-merge
September 8, 2025 14:04
rami3l
force-pushed
the
feat/concurrent-download-default
branch
from
September 8, 2025 14:32
2fc451f to
b3640c8
Compare
…CONCURRENT_DOWNLOADS` is set to 1
…stalling toolchains
rami3l
force-pushed
the
feat/concurrent-download-default
branch
from
September 8, 2025 14:58
b3640c8 to
6d5ec41
Compare
rami3l
enabled auto-merge
September 8, 2025 14:59
rami3l
added this pull request to the merge queue
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am currently test-driving the new concurrent downloads implementation and would like to try out different download counts. However when doing so I noticed that the previous decision of make both
rustup checkandrustup toolchainshare a common default concurrent download count might not be optimal.Thus, with this PR:
rustup checkunless the download count is overridden to 1.