Skip to content

fix(rustup-init/sh): fix incorrect TLS warning with curl v8.10 - #4046

Merged
rami3l merged 1 commit into
masterfrom
rami3l-patch-1
Oct 11, 2024
Merged

rami3l merged 1 commit into
masterfrom
rami3l-patch-1

Conversation

@rami3l

@rami3l rami3l commented Oct 11, 2024

Copy link
Copy Markdown
Member

Closes #4045, as discussed in #4045 (comment).

Tested locally on Alpine Linux v3.20 aarch64 with the following cURL distribution:

> curl --version
curl 8.10.1 (aarch64-alpine-linux-musl) libcurl/8.10.1 OpenSSL/3.3.2 zlib/1.3.1 brotli/1.1.0 zstd/1.5.6 c-ares/1.33.1 libidn2/2.3.7 libpsl/0.21.5 nghttp2/1.62.1
Release-Date: 2024-09-18
Protocols: dict file ftp ftps gopher gophers http https imap imaps ipfs ipns mqtt pop3 pop3s rtsp smb smbs smtp smtps telnet tftp ws wss
Features: alt-svc AsynchDNS brotli HSTS HTTP2 HTTPS-proxy IDN IPv6 Largefile libz NTLM PSL SSL threadsafe TLS-SRP UnixSockets zstd

@rami3l
rami3l requested a review from djc October 11, 2024 08:41
@djc

djc commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

Nice!

@rami3l
rami3l enabled auto-merge October 11, 2024 08:49
@rami3l
rami3l added this pull request to the merge queue Oct 11, 2024
Merged via the queue into master with commit a9c4362 Oct 11, 2024
@rami3l
rami3l deleted the rami3l-patch-1 branch October 11, 2024 09:23
perlun added a commit to perlang-org/perlang that referenced this pull request Jan 16, 2026
This incorporates the fix from
rust-lang/rustup#4046 into our code base as
well. (I saw in rust-lang/rustup#4045 that
other projects have also been inspired by this fix in rustup. :-)

Fixes #509
perlun added a commit to perlang-org/perlang that referenced this pull request Jan 16, 2026
This incorporates the fix from
rust-lang/rustup#4046 into our code base as
well. (I saw in rust-lang/rustup#4045 that
other projects have also been inspired by this fix. :-)

Fixes #509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rustup TLS warning with newer curl versions (v8.10.0+)

2 participants