Skip to content

Use indicatif as the progress bar - #3349

Closed
0xPoe wants to merge 2 commits into
rust-lang:masterfrom
0xPoe:rustin-patch-indicatif
Closed

0xPoe wants to merge 2 commits into
rust-lang:masterfrom
0xPoe:rustin-patch-indicatif

Conversation

@0xPoe

@0xPoe 0xPoe commented May 6, 2023 •

Copy link
Copy Markdown
Member

Close #2828

Close #1826

Close #1835

Big thanks for #2828

@0xPoe
0xPoe force-pushed the rustin-patch-indicatif branch 2 times, most recently from 44ef07c to 9efea91 Compare May 6, 2023 02:07
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@0xPoe
0xPoe force-pushed the rustin-patch-indicatif branch from 9efea91 to 3572f82 Compare July 5, 2023 01:07
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@ryanavella

Copy link
Copy Markdown

I can confirm this resolves the issue for me on FreeBSD + xterm[-256color]. My symptoms were identical to #1826 even though that was reported for a different environment (Alacritty + ConPTY)

@0xPoe

0xPoe commented Aug 6, 2023

Copy link
Copy Markdown
Member Author

This PR will cause some display issues when changing the window size of the terminal. So I am going to close it for now.

@0xPoe 0xPoe closed this Aug 6, 2023
@0xPoe

0xPoe commented Nov 18, 2024

Copy link
Copy Markdown
Member Author

I will revisit it and try to fix the resize issue.

cc: @rust-lang/rustup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate using a community maintained progress bar Progress indicator broken on Alacritty with ConPTY

2 participants