Skip to content

Remove header license info - #1733

Merged
kinnison merged 1 commit into
rust-lang:masterfrom
srinivasreddy:1732
Apr 2, 2019
Merged

kinnison merged 1 commit into
rust-lang:masterfrom
srinivasreddy:1732

Conversation

@srinivasreddy42

@srinivasreddy42 srinivasreddy42 commented Mar 30, 2019 •

Copy link
Copy Markdown

@kinnison

Copy link
Copy Markdown
Contributor

As I said on the issue, I'm unclear why this is valuable to do.

@nrc

nrc commented Apr 1, 2019

Copy link
Copy Markdown
Member

I think it is reasonable to do, it brings the script file in line with the rust files (where the license boilerplate was removed along with that in the main Rust repo)

@kinnison kinnison mentioned this pull request Apr 2, 2019
@kinnison

kinnison commented Apr 2, 2019

Copy link
Copy Markdown
Contributor

@nrc Fair enough, I'll remove my mild concern then :D

@kinnison kinnison reopened this Apr 2, 2019

@kinnison kinnison left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on @nrc's agreement, I withdraw my mild concern.

@kinnison
kinnison merged commit f07e26f into rust-lang:master Apr 2, 2019
@srinivasreddy42
srinivasreddy42 deleted the 1732 branch April 3, 2019 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants