Skip to content

add feature based on issue #1033 - #1375

Closed
serabiasin wants to merge 1 commit into
rust-lang:masterfrom
serabiasin:inspirational-quote
Closed

serabiasin wants to merge 1 commit into
rust-lang:masterfrom
serabiasin:inspirational-quote

Conversation

@serabiasin

Copy link
Copy Markdown

im still new in open source community please guide me :)

@bors

bors commented Apr 13, 2018

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #1390) made this pull request unmergeable. Please resolve the merge conflicts.

@cyplo

cyplo commented Apr 14, 2018

Copy link
Copy Markdown
Contributor

Heya !
Thank you for the PR :)
It may help to rename the subject to let people know what the issue was about - this way you can save them a click :)

My PR that formats all the code #1390 made changes to the same lines you made the changes too - you may want to look into that - let me know if you'd need help with that (twitter is best)

For merging this one - while I can offer advice on the code changes I cannot merge the PR myself and the maintainers experience a period of more intense work, hence the PR can wait in their queue a bit - don't be discouraged by it !

@Diggsey

Diggsey commented May 27, 2018

Copy link
Copy Markdown
Contributor

Hi @serabiasin, thanks for the PR.

However, the issue you referenced describes adding a message to the rustup self help subcommand. I also think it should be something other than a hard-coded quote. If you have any ideas for an interesting/fun easter-egg here, feel free to comment on the issue or open a new PR.

Also, as @cyplo explained, it's a good idea to include a more descriptive title, and link to the relevant issue in the PR description.

@Diggsey Diggsey closed this May 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants