Skip to content

Demote deprecation warning to verbose info #2149

Description

@kinnison

After a lot of discussion with reddit and friends, it seems that deprecating rustup install and rustup uninstall would have consequences I'd not considered (printed books) and as such it'd be unpleasantly surprising for new users to be told the book they bought was wrong.

As such, we should demote the deprecation warning code from warn!() to verbose!() and make it clear that the reason for the message is that until true alias support is added, these may not function quite as the toolchain XXX commands would.

Long-term we want to replace the deprecated subcommands with true aliases so that this can't be a problem again in the future.

Activity

  1. added this to the 1.21.0 milestone on Dec 9, 2019
  2. kinnison commented on Dec 9, 2019

    @kinnison
    ContributorAuthor

    If you'd like to tackle this, please indicate so on the issue and find me on the Rustup discord channel if you want to chat about it.

  3. jaronsummers commented on Dec 9, 2019

    @jaronsummers

    The printed book use case is largely handled by just replacing the existing code with a message that says to use rustup toolchain install instead, isn't it? That code would be simple enough that it wouldn't be buggy, nor would it be a duplication of the rustup toolchain install code.

  4. kinnison commented on Dec 10, 2019

    @kinnison
    ContributorAuthor

    @jaronsummers This issue was raised precisely because people were worried about such a deprecation message causing undue concern to newcomers.

  5. added a commit that references this issue on Dec 16, 2019
    4f0f6b1
  6. self-assigned this
    on Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions