Skip to content

fix Layout struct member naming style - #93408

Merged
bors merged 1 commit into
rust-lang:masterfrom
liangyongrui:master
Apr 12, 2022
Merged

bors merged 1 commit into
rust-lang:masterfrom
liangyongrui:master

Conversation

@liangyongrui

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 28, 2022
@rust-log-analyzer

This comment has been minimized.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 28, 2022
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@camelid camelid added T-libs Relevant to the library team, which will review and decide on the PR/issue. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 3, 2022
@camelid

camelid commented Mar 3, 2022

Copy link
Copy Markdown
Member

Hi @liangyongrui, thanks for your PR! rust-lang/rust follows a "No-Merge Policy", so could you please rebase over upstream changes instead of merging? Thanks!

@liangyongrui

Copy link
Copy Markdown
Contributor Author

@camelid OK. I have rebased.

@bors

bors commented Apr 9, 2022

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #95855) made this pull request unmergeable. Please resolve the merge conflicts.

@liangyongrui
liangyongrui force-pushed the master branch 2 times, most recently from 587af13 to 94a69bf Compare April 11, 2022 05:33
@camelid

camelid commented Apr 11, 2022

Copy link
Copy Markdown
Member

r? @scottmcm

@rust-highfive rust-highfive assigned scottmcm and unassigned kennytm Apr 11, 2022
@scottmcm

Copy link
Copy Markdown
Member

Oh, if the _s aren't needed for something, this makes good sense to me!

@bors r+

@bors

bors commented Apr 11, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 03b2588 has been approved by scottmcm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2022
@bors

bors commented Apr 11, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 03b2588 with merge d6d4402823ca77ccb0b9196cd4c19998dccf39ee...

@Dylan-DPC

Copy link
Copy Markdown
Member

@bors retry yield to rollup

@bors

bors commented Apr 12, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 03b2588 with merge 36f4ded...

@bors

bors commented Apr 12, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: scottmcm
Pushing 36f4ded to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 12, 2022
@bors
bors merged commit 36f4ded into rust-lang:master Apr 12, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 12, 2022
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (36f4ded): comparison url.

Summary:

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvements found
Regressions 😿
(primary)
Regressions 😿
(secondary)
Improvements 🎉
(primary)
Improvements 🎉
(secondary)
All 😿 🎉
(primary)
count1 0 0 0 2 0
mean2 N/A N/A N/A -0.5% N/A
max N/A N/A N/A -0.5% N/A

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes ↩

  2. the arithmetic mean of the percent change ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants