Repository navigation
Conversation
Contributor
|
Bot failure is Valgrind complaining LLVM module and context are leaked. Duh... |
Contributor
|
@brson is there a way to silence valgrind? |
Contributor
|
@cmr Valgrind can be silenced by adding new supressions to |
Contributor
Author
|
It's only a subset of the tests where valgrind is actually valgrinding rustc. I'll investigate. Trying to revive this patch. |
Contributor
Author
|
Not going to finish this. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 28, 2021
Change `while_let_on_iterator` suggestion to use `by_ref()` It came up in the discussion rust-lang#7659 that suggesting `iter.by_ref()` is a clearer suggestion than `&mut iter`. I personally think they're equivalent, but if `by_ref()` is clearer to people then that should be the suggestion. changelog: Change `while_let_on_iterator` suggestion when using `&mut` to use `by_ref()`
U007D
pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
7659: Improve "Generate From impl" r=Veykril a=jDomantas * Allows any field type. Previously it was restricted to path types, but I don't see why it couldn't apply to all other types too. (the main reason for is PR is that I'm too lazy to write out `From<&'static str>` by hand 😄) * More correct handling for generic enums - previously it wouldn't emit generic params on the impl. * Also accepts variants with named field. The impl generation code got mostly copy-pasted from generate_impl assist - please tell if there's an easy way to avoid this duplication. Co-authored-by: Domantas Jadenkus <djadenkus@gmail.com>
U007D
pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
7664: refactor impl generation in assists r=Veykril a=jDomantas Follow-up to rust-lang#7659: all impl generation in assists (at least what I found) is now done through `utils::{generate_impl_text, generate_trait_impl_text}`. Co-authored-by: Domantas Jadenkus <djadenkus@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During normal batch operation, rustc will not bother to dispose of the LLVM module and context in order to save some time.